qa/workunits/rados/test_envlibrados_for_rocksdb: install g++ not g++-4.7 #22103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
since fog now deploys ubuntu 18.04 where g++-4.7 is not available anymore, so g++ is good enough. Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-qa-test_envlibrados_for_rocksdb
branch
6 times, most recently
from
65efd73
to
5694a93
Compare
tchaikov
added
wip-kefu-testing
needs-qa
wip-kefu-testing2
and removed
wip-kefu-testing
labels
tchaikov
force-pushed
the
wip-qa-test_envlibrados_for_rocksdb
branch
from
5694a93
to
c262d46
Compare
* so we just rely on a single build system instead of two of them, the other place we use cmake is cmake/modules/BuildRockDB.cmake. * disable gflags when building rocksdb, it's optional and does not help in the sense of testing librados support. * disable prompts when installing on debian, to silence warnings like: debconf: unable to initialize frontend: Dialog * drop --force-yes option, as it is deprecated, and is replaced with --allow-downgrades, --allow-remove-essential, --allow-change-held-packages, but none of them apply in our case. Signed-off-by: Kefu Chai <kchai@redhat.com>
so we dont't need to force librados client to move to C++14 or up. Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-qa-test_envlibrados_for_rocksdb
branch
from
c262d46
to
2b904ae
Compare
jdurgin
approved these changes
May 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since fog now deploys ubuntu 18.04 where g++-4.7 is not available
anymore, so g++ is good enough.
Signed-off-by: Kefu Chai kchai@redhat.com