mimic: osd crashes in on_local_recover due to stray clone #22671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is a stray clone (one that does not appear in the SnapSet) and we do any sort of recovery on it the OSD will crash. Log an error instead but continue. This addresses a problem where a cluster has both (1) an unexpected clone and (2) the clone is not present on all replicas. Doing repair on that PG will both not fix the unexpected clone and also cause the remaining OSDs to crash trying to recover it. Include a test. Fixes: https://tracker.ceph.com/issues/24396 Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit 154330f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/24470