mgr/dashboard: Remove top-right actions text and add "About" page #22762
Conversation
|
jenkins retest this please |
There was a problem hiding this comment.
@ricardoasmarques according to proposal, the about modal should be patternfly( http://www.patternfly.org/pattern-library/communication/about-modal/ ) based.
|
@a2batic by “patternfly based” you mean that I should use the same HTML structure and css classes from the patternfly, but I do not have to import patternfly. Or should I also import patternfly into Ceph dashboard project? |
|
jenkins retest this please |
LenzGr
changed the title
|
@ricardoasmarques I had a doubt that we would be following patternfly library or patternfly-like modal after proposal. But, this looks good. I will test this and send my reviews. |
|
jenkins retest this please |
| constructor(public modalRef: BsModalRef, private summaryService: SummaryService) {} | ||
|
|
||
| ngOnInit() { | ||
| this.summaryService.get().subscribe((summary: any) => { |
There was a problem hiding this comment.
We could remove a new request to the backend if, instead of calling get, we subscribe to the service.
We might need to replace Subject observable with BehaviorSubject, so we can obtain the value as soon as we subscribe.
| outsideClick="true"> | ||
| outsideClick="true" | ||
| i18n-title | ||
| title="Recent Notifications"> | ||
| <i class="fa fa-bell"></i> |
There was a problem hiding this comment.
We should add fa-fw to all the icons on the navbar and remove the margin-right.
ATM they don't have the same size and spacing.
|
According to patternfly the label and version in the about modal should stay in the same line, but ceph version is too big and it automatically breaks. Would it be ok to force a few more breaks? I think the result is more appealing to the eye: We could also keep the 1st part in the 1st line: |
| @@ -0,0 +1,23 @@ | |||
| .product-versions { | |||
| margin-bottom: 30px; | |||
There was a problem hiding this comment.
I think this can be removed or reduced.
|
@tspmelo I'd be in favor of the second proposal (keep the actual version number in the same line as the "Ceph version" string and put the git commit hash and release code name underneath) |
|
@tspmelo, I am also in favor of second one. |
|
2nd as well. The only thing PF states about "about box" text is:
Another approach would be splitting version into x.y.z, build and commit components through a pipe, but I don't think it's worthy. BTW, this version string is taken at runtime from the ceph-mgr, right? So in case of upgrades, it will only change after the mgr/dashboard has been upgraded and restarted. |
ricardoasmarques
force-pushed
the
wip-toolbar-text
branch
3 times, most recently
from
c768178
to
92f86f1
Compare
|
@tspmelo I've addressed your comments |
Fixes: https://tracker.ceph.com/issues/24624 Signed-off-by: Ricardo Marques <rimarques@suse.com>
Signed-off-by: Ricardo Marques <rimarques@suse.com>
Fixes: https://tracker.ceph.com/issues/24646 Signed-off-by: Ricardo Marques <rimarques@suse.com>
ricardoasmarques
force-pushed
the
wip-toolbar-text
branch
from
92f86f1
to
6c33d7f
Compare
|
jenkins retest this please |
This PR removes actions text from the top-right toolbar:
and adds "About" page:
Fixes: https://tracker.ceph.com/issues/24624