librbd:optionally support FUA (force unit access) on write requests #22945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dillaman : make sense？ |
|
@cxytt Can you add a "Signed-of-by" line to your commit? It would also be nice to add a unit test to "src/test/librbd/test_librbd.cc" where it opens the same image twice, issues a flush (to switch the cache into writeback mode) and a FUA write on the first image handle and then attempts to immediately read the data using the second image handle. |
|
... also add a "Fixes: http://tracker.ceph.com/issues/19366" line to your commit message |
|
@dillaman right, i will fix as you say |
Fixes: http://tracker.ceph.com/issues/19366 Signed-off-by: ningtao <63358@sangfor.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add flag LIBRADOS_OP_FLAG_FADVISE_FUA