mds: print mdsmap processed at low debug level #23061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is reasonable, given how rarely the MDSMap changes. Since the default log levels are mainly reserved for warnings and errors, it might be good to rephrase this a bit to make it clearer to the uninitiated that it's nothing to worry about, like "Updated to MDS map version X". It's less direct phrasing, but that's perhaps the cost of doing business for log messages that are going to be in front of end user eyeballs by default. |
Production deployments use low debugging but it'd be useful to always know what MDSMap epoch the MDS is currently processing. (In the case of skipped epochs or unsynchronized processing.) Fixes: https://tracker.ceph.com/issues/24852 Signed-off-by: Patrick Donnelly <pdonnell@redhat.com>
|
That's a good point. Thanks @jcsp and updated. |
jcsp
approved these changes
Jul 16, 2018
|
retest this please |
batrick
added a commit
that referenced
this pull request
Jul 21, 2018
* refs/pull/23061/head: mds: print mdsmap processed at low debug level Reviewed-by: John Spray <john.spray@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Production deployments use low debugging but it'd be useful to always know what
MDSMap epoch the MDS is currently processing. (In the case of skipped epochs or
unsynchronized processing.)
Fixes: https://tracker.ceph.com/issues/24852
Signed-off-by: Patrick Donnelly pdonnell@redhat.com