mon/OSDMonitor: Warnings for expected_num_objects #23072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neha-ojha
reviewed
Jul 16, 2018
src/mon/OSDMonitor.cc
Outdated
| if (expected_num_objects == 0 && | ||
| cct->_conf->osd_objectstore == "filestore" && | ||
| cct->_conf->filestore_merge_threshold < 0) { | ||
| if (pg_num >= 1024 || pg_num / osdmap.get_num_osds() >= 50) { |
There was a problem hiding this comment.
Did we change the num of pgs per osd threshold from 100 to 50?
There was a problem hiding this comment.
Didn't we? I thought we did in the last conversation we had. If you think we should keep at 100, I'm ok with that.
jdurgin
reviewed
Jul 16, 2018
src/mon/OSDMonitor.cc
Outdated
| if (expected_num_objects == 0 && | ||
| cct->_conf->osd_objectstore == "filestore" && | ||
| cct->_conf->filestore_merge_threshold < 0) { | ||
| if (pg_num >= 1024 || pg_num / osdmap.get_num_osds() >= 50) { |
There was a problem hiding this comment.
should check for divide by zero here - you could have no osds
jdurgin
approved these changes
Jul 17, 2018
|
@jdurgin, @neha-ojha pointed out that I mentioned 100 PGs/OSD as the threshold before (and once since) writing this code. Did we settle on 50 or was it 100 the whole time? |
|
I don't remember 50, but I'm happy either way.
Sent from Nine
…________________________________
From: fullerdj <notifications@github.com>
Sent: Tuesday, July 17, 2018 9:24 AM
To: ceph/ceph
Cc: Josh Durgin; Mention
Subject: Re: [ceph/ceph] Warnings for expected_num_objects (#23072)
@jdurgin, @neha-ojha pointed out that I mentioned 100 PGs/OSD as the threshold before (and once since) writing this code. Did we settle on 50 or was it 100 the whole time?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#23072 (comment)
|
|
Ok, I changed it to 100.
… On Jul 17, 2018, at 12:55 PM, Josh Durgin ***@***.***> wrote:
I don't remember 50, but I'm happy either way.
Sent from Nine
________________________________
From: fullerdj ***@***.***>
Sent: Tuesday, July 17, 2018 9:24 AM
To: ceph/ceph
Cc: Josh Durgin; Mention
Subject: Re: [ceph/ceph] Warnings for expected_num_objects (#23072)
@jdurgin, @neha-ojha pointed out that I mentioned 100 PGs/OSD as the threshold before (and once since) writing this code. Did we settle on 50 or was it 100 the whole time?
--
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#23072 (comment)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
neha-ojha
approved these changes
Jul 17, 2018
yuriw
added
mimic-batch-1
wip-yuri2-testing
wip-yuri-testing
and removed
wip-yuri2-testing
labels
|
@neha-ojha this needs to be fixed/rebased https://pastebin.com/wu5aaXZz |
The expected_num_objects argument to ceph osd pool create is only effective on filestore pools when merging is disabled (filestore_merge_threshold < 0). Warn and disallow pool creation in this situation. Signed-off-by: Douglas Fuller <dfuller@redhat.com>
|
still broken https://pastebin.com/6kdiUsgU |
smithfarm
changed the title
|
[dnm] added while pgcalc discussion is ongoing. |
When creating a pool on filestore, warn if the user appears to be creating a pool to store a large number of objects but omitted the expected_num_objects parameter. Create the pool anyway. Fixes: http://tracker.ceph.com/issues/24687 Signed-off-by: Douglas Fuller <dfuller@redhat.com>
|
Message updated and DNM tag removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warn if the user tries to create a pool with wrong or missing expected_num_objects