Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSD: ceph-osd parent process need to restart log service after fork #23090

Merged
merged 1 commit into from
Oct 22, 2018

Conversation

simpleshuai
Copy link

@simpleshuai simpleshuai commented Jul 17, 2018

Fixes: http://tracker.ceph.com/issues/24956
Signed-off-by: redickwang redickwang@tencent.com

osd: ceph-osd parent process need to restart log service after fork
log service not started, osd will hang on ceph::logging::Log::submit_entry when the option log_max_new in ceph.conf set to zero

@simpleshuai simpleshuai changed the title ceph-osd parent process need to restart log service after fork OSD: ceph-osd parent process need to restart log service after fork Jul 17, 2018
@yuriw
Copy link
Contributor

yuriw commented Jul 20, 2018

@neha-ojha
Copy link
Member

Please align this PR to the requirements described in https://github.com/ceph/ceph/blob/master/SubmittingPatches.rst.

Particularly, it should have the tracker reference in the following manner:
Fixes: http://tracker.ceph.com/issues/24956
Signed-off-by: ...

The commit message should start with component name.
Example:

osd: short description

longer description

…or ceph-osd will not work correctly when the option log_max_new in ceph.conf set to zero

Signed-off-by: redickwang <redickwang@tencent.com>
@simpleshuai
Copy link
Author

@neha-ojha Done

@stale
Copy link

stale bot commented Oct 17, 2018

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you are a maintainer or core committer, please follow-up on this issue to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

@stale stale bot added the stale label Oct 17, 2018
@tchaikov tchaikov merged commit 09c31bb into ceph:master Oct 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants