doc: rewrote the iscsi-target-cli installation

[maxcuttins]

Rewrote the documentation in a step-by-step style, reformatted using RST's titles instead of bolds, added installation of GIT if needed, added installation of compilers needed for tcmu-runner

Signed-off-by: Massimiliano Cuttini massimiliano.cuttini@phoenixweb.it

[dillaman]

jenkins render docs

[ceph-jenkins]

Doc render available at http://docs.ceph.com/ceph-prs/23190/

[maxcuttins]

make check failed?

[ceph-jenkins]

Doc render available at http://docs.ceph.com/ceph-prs/23190/

[maxcuttins]

@dillaman I really don't know why "make checks" failed

[tchaikov]

jenkins, retest this please

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If you are a maintainer or core committer, please follow-up on this issue to identify what steps should be taken by the author to move this proposed change forward.
If you are the author of this pull request, thank you for your proposed contribution. If you believe this change is still appropriate, please ensure that any feedback has been addressed and ask for a code review.

[LenzGr]

Hi @maxcuttins thanks for your contribution - would it be possible for you to make the amendments requested by @dillaman so this PR can be merged?

[ceph-jenkins]

Doc render available at http://docs.ceph.com/ceph-prs/23190/

[maxcuttins]

Hi @maxcuttins thanks for your contribution - would it be possible for you to make the amendments requested by @dillaman so this PR can be merged?

To me it's a nightmare to apply these changes because my GIT try to solve many submodule/repos appear to be broken on my client. I just want to contribute to the DOC, but instead I face problem with make checks and other staff.

I update the doc from the online editor of github and seems fine.

However, next time, just modify directly.
To me was just fine update the big changes not right in the documentation but really I don't know all the internal redhat rules to write in your way. So, If I can suggest you a faster way to approve changes, I think that minor/formal reviews can be apply later by a second reviewer to have a uniform documentation.
This allow you to approve quickly big big big difference in the documentation that need to be updated as soon as possible. :)

[maxcuttins]

News?

[LenzGr]

The documentation build check failed with the following error:

Warning, treated as error:
/home/jenkins-build/build/workspace/ceph-pr-docs/doc/rbd/iscsi-target-cli-manual-install.rst:68: (WARNING/2) Title underline too short.

Could you please correct this?

[LenzGr]

And yes, the process of updating the documentation is somewhat involved. Thanks for your endurance 👍 - did you see the chapter "Documenting Ceph" in the documentation? This should explain the process and expectations in more detail.

[LenzGr]

Thank you for fixing the latest failure. Unfortunately the "Signed-off-by" check fails - please make sure that commits are properly signed-off using git commit -s.

@dillaman OK to merge from your POV? Then I'd suggest @maxcuttins to squash all changes into a single commit before merging.

[LenzGr]

jenkins render docs

[ceph-jenkins]

Doc render available at http://docs.ceph.com/ceph-prs/23190/

[LenzGr]

@dillaman any thoughts on this change?

[dillaman]

jenkins render docs

[ceph-jenkins]

Doc render available at http://docs.ceph.com/ceph-prs/23190/