Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common/config: fix the lock in ConfigProxy::diff() #23276

Merged
merged 1 commit into from
Jul 30, 2018
Merged

common/config: fix the lock in ConfigProxy::diff() #23276

merged 1 commit into from
Jul 30, 2018

Conversation

tchaikov
Copy link
Contributor

it's a regression introduced by e406d8e

Signed-off-by: Kefu Chai kchai@redhat.com

@tchaikov
common/config: fix the lock in ConfigProxy::diff()
40e76aa 
it's a regression introduced by e406d8e

Signed-off-by: Kefu Chai <kchai@redhat.com>
@tchaikov tchaikov requested review from jdurgin and cbodley July 27, 2018 04:15
@tchaikov tchaikov mentioned this pull request Jul 27, 2018
Merged
@tchaikov
Copy link
Contributor Author

retest this please.

@tchaikov
Copy link
Contributor Author

@liu-chunmei mind taking a look?

@tchaikov
Copy link
Contributor Author 

FAIL src/app/shared/components/deletion-modal/deletion-modal.component.spec.ts
  ● Test suite failed to run

    SecurityError: localStorage is not available for opaque origins

      at Window.get localStorage [as localStorage] (node_modules/jsdom/lib/jsdom/browser/Window.js:257:15)
          at Array.forEach (<anonymous>)

retest this please.

@tchaikov
Copy link
Contributor Author

retest this please.

@tchaikov
Copy link
Contributor Author

@tchaikov tchaikov merged commit df2196d into ceph:master Jul 30, 2018
@tchaikov tchaikov deleted the wip-config-diff-lock branch July 30, 2018 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdurgin jdurgin jdurgin approved these changes

@cbodley cbodley cbodley approved these changes

Assignees
No one assigned
Labels
bug-fix common needs-qa wip-kefu-testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tchaikov @jdurgin @cbodley