mimic: mgr: Ignore daemon if no metadata was returned #23356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can happen that the Mgr does not return any metadata for a given daemon as it might not be available at that moment. None is returned by the get_metadata() method at that moment and both the Influx and Telegraf module should then ignore the daemon in their statistics and continue on to the next daemon. Signed-off-by: Wido den Hollander <wido@42on.com> (cherry picked from commit 02569c8)
|
This fixes https://tracker.ceph.com/issues/25191 |
|
This is a backport of #22794 |
jcsp
approved these changes
Aug 1, 2018
|
retest this please |
|
Can this one go into Mimic? |
|
I guess this one is not forgotten but just waiting until the next round of backport testing (@smithfarm can config) |
|
@jcsp Correct. As long as the milestone is set correctly, it is definitely not forgotten. |
smithfarm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://tracker.ceph.com/issues/25202
It can happen that the Mgr does not return any metadata for a given
daemon as it might not be available at that moment.
None is returned by the get_metadata() method at that moment and both
the Influx and Telegraf module should then ignore the daemon in their
statistics and continue on to the next daemon.
Signed-off-by: Wido den Hollander wido@42on.com
(cherry picked from commit 02569c8)