run-make-check: Showing configuration before the build #23609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smithfarm
reviewed
Aug 16, 2018
run-make-check.sh
Outdated
| @@ -123,7 +123,7 @@ EOM | |||
| echo "Current ccache max_size setting:" | |||
| ccache -p | grep max_size | |||
| fi | |||
| $DRY_RUN ccache -z # Reset the ccache statistics | |||
| $DRY_RUN ccache -sz # Reset the ccache statistics & show the current configuration | |||
There was a problem hiding this comment.
This is just a nit, but I don't like & ampersands in code comments (the ampersand seems like a special character, so my eyes trip over it when reading). Would you mind replacing the ampersand with the word "and"?
The actual code is resetting the statistics before doing the actual compilation and prints them after the build. That is nice to understand how much the cache was used but doesn't help understanding how much it _could_ have been used. This patch is adding a reporting (-s) when cleaning the statistics so we can estimate : - the actual number of files in cache - the actual size of the cache With this two missing information, its now possible estimate if there is some miss-usage of the cache. Signed-off-by: Erwan Velu <erwan@redhat.com>
ErwanAliasr1
force-pushed
the
evelu-ccache
branch
from
39f3943
to
d1a807a
Compare
|
@smithfarm updated. |
smithfarm
approved these changes
Aug 17, 2018
|
@ErwanAliasr1 next time, when you are merging a PR, could please add a "Reviewed-by: " line in the merge commit? |
|
@tchaikov Oh ok. Sorry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The actual code is resetting the statistics before doing the actual compilation and prints them after the build.
That is nice to understand how much the cache was used but doesn't help understanding how much it could have been used.
This patch is adding a reporting (-s) when cleaning the statistics so we can estimate :
With this two missing information, its now possible estimate if there is some miss-usage of the cache.
Signed-off-by: Erwan Velu erwan@redhat.com