mgr/dashboard: Auto-create a name for RBD image snapshots #23735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
votdev
force-pushed
the
suggest_snapshot_name
branch
from
5c68eed
to
05085ef
Compare
LenzGr
approved these changes
Aug 27, 2018
tspmelo
suggested changes
Aug 28, 2018
| } else { | ||
| // Auto-create a name for the snapshot: <image_name>_<timestamp_ISO_8601> | ||
| // https://en.wikipedia.org/wiki/ISO_8601 | ||
| snapName = `${this.rbdName}-${moment().format('YYYYMMDD[T]HHmmss[Z]')}`; |
There was a problem hiding this comment.
Since Z indicates you are using the Zulu timezone, you need to convert the date to UTC before doing the format.
- snapName = `${this.rbdName}-${moment().format('YYYYMMDD[T]HHmmss[Z]')}`;
+ snapName = `${this.rbdName}-${moment().utc().format('YYYYMMDD[T]HHmmss[Z]')}`;
There was a problem hiding this comment.
Thx, seems i misunderstood the docu. I thought moment() is just UTC.
votdev
force-pushed
the
suggest_snapshot_name
branch
from
05085ef
to
5f3b13c
Compare
LenzGr
changed the title
Devp00l
previously requested changes
Aug 29, 2018
...d/mgr/dashboard/frontend/src/app/ceph/block/rbd-snapshot-list/rbd-snapshot-list.component.ts
Outdated
Show resolved
Hide resolved
votdev
force-pushed
the
suggest_snapshot_name
branch
2 times, most recently
from
67e99b2
to
4503091
Compare
tspmelo
approved these changes
Aug 30, 2018
votdev
force-pushed
the
suggest_snapshot_name
branch
2 times, most recently
from
9a7cfa8
to
d9efce2
Compare
|
retest this please |
votdev
force-pushed
the
suggest_snapshot_name
branch
from
d9efce2
to
22429a5
Compare
Signed-off-by: Volker Theile <vtheile@suse.com>
votdev
force-pushed
the
suggest_snapshot_name
branch
from
22429a5
to
bc52473
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user creates an snapshot of a RBD image, then a name according to ISO 8601 (<image_name>_<timestamp_ISO_8601>, e.g. test01-20180824T170532Z) will be auto-created. This can still be modified by the user.
Note, the timestamp encoded in the snapshot name is NOT the real creation date (that's because the snapshot is created after you pressed the
Create Snapshotbutton and the timestamp is the one when the dialog appears in the UI). To workaround this issue we can drop the HHMMSS part from the snapshot name if necessary.Signed-off-by: Volker Theile vtheile@suse.com