test/crimson: do not use unit.cc as the driver of unittest_seastar_denc #23937
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as unit.cc initializes the CephContext and all of Ceph's infratructure, which is not necessary for the denc test. also, seastar's builtin allocator only pre-allocates 32 << 20 bytes. it's enough for the denc test, but not necessarily enough for create CephContext and its friends. an option is to use seastar's app template to initialize the memory allocator properly. another option is to avoid initializing CephContext in this test. the latter is simpler. Signed-off-by: Kefu Chai <kchai@redhat.com>
cbodley
approved these changes
Sep 5, 2018
|
ceph-jenkins is really persistent .. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as unit.cc initializes the CephContext and all of Ceph's infratructure,
which is not necessary for the denc test. also, seastar's builtin allocator
only pre-allocates 32 << 20 bytes. it's enough for the denc test, but
not necessarily enough for create CephContext and its friends. an option is
to use seastar's app template to initialize the memory allocator properly.
another option is to avoid initializing CephContext in this test.
the latter is simpler.
Signed-off-by: Kefu Chai kchai@redhat.com