os/bluestore: fix bloom filter num entry miscalculation in repairer #24076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liewegas
approved these changes
Sep 13, 2018
|
Should this get a tracker so that we remember to backport to mimic and luminous? |
This could cause an assertion due to an access to uninitialized bloom filter. This happened when detecting errors involving physical extents close to the end of a large partition. E.g. it was observed in http://tracker.ceph.com/issues/25001 while trying to repair an OSD. Fixes: https://tracker.ceph.com/issues/35971 Signed-off-by: Igor Fedotov <ifedotov@suse.com>
ifed01
force-pushed
the
wip-ifed-fix-repairer
branch
from
7cfa076
to
5091981
Compare
|
@ifed01 i am adding "backport=mimic" to the related tracker ticket, as i believe this bug also impacts that release. please correct it, if i am wrong. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could cause an assertion due to an access to uninitialized bloom
filter. This happened when detected errors involving physical extents were
close to the end of a large partition.
E.g. it was observed in http://tracker.ceph.com/issues/25001 while trying to repair an OSD.
Fixes: https://tracker.ceph.com/issues/35971
Signed-off-by: Igor Fedotov ifedotov@suse.com