Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common: fix memory leaks in WeightedPriorityQueue. #24331

Merged
merged 1 commit into from
Oct 11, 2018

Conversation

rzarzynski
Copy link
Contributor

@rzarzynski rzarzynski commented Sep 28, 2018

Fixes: http://tracker.ceph.com/issues/36248
Signed-off-by: Radoslaw Zarzynski rzarzyns@redhat.com

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Fixes: http://tracker.ceph.com/issues/36248
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
Copy link
Member

@jdurgin jdurgin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right. Are we not hitting it in valgrind tests because we're clearing the queue before shutdown?

@rzarzynski
Copy link
Contributor Author

Are we not hitting it in valgrind tests because we're clearing the queue before shutdown?

I think so. The issue popped up solely in the unittest where we don't pop() the stuff at the end.

@liewegas liewegas merged commit 61395d4 into ceph:master Oct 11, 2018
liewegas added a commit that referenced this pull request Oct 11, 2018
* refs/pull/24331/head:
	common: fix memory leaks in WeightedPriorityQueue.

Reviewed-by: Josh Durgin <jdurgin@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants