Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: Confirmation modal doesn't close #24544

Merged
merged 1 commit into from
Oct 23, 2018
Merged

Conversation

votdev
Copy link
Member

@votdev votdev commented Oct 11, 2018

Fixes: https://tracker.ceph.com/issues/24729

Signed-off-by: Volker Theile vtheile@suse.com

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Copy link
Contributor

@ricardoasmarques ricardoasmarques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the make check failure, LGTM.

@tspmelo
Copy link
Contributor

tspmelo commented Oct 12, 2018

jenkins retest this please

@callithea
Copy link
Member

jenkins test make check

Fixes: https://tracker.ceph.com/issues/24729

Signed-off-by: Volker Theile <vtheile@suse.com>
Copy link

@Devp00l Devp00l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💯

@LenzGr LenzGr merged commit 5727f9b into ceph:master Oct 23, 2018
@votdev votdev deleted the bug_24729 branch October 23, 2018 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants