Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mimic: ceph-volume: make lvm batch idempotent #24588

Merged
merged 23 commits into from
Oct 24, 2018
Merged

mimic: ceph-volume: make lvm batch idempotent #24588

merged 23 commits into from
Oct 24, 2018

Conversation

andrewschoen
Copy link
Contributor

backport of #24404

@andrewschoen
ceph-volume: add vg_name to the Device class
81f498d 
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
(cherry picked from commit 619810c)
@andrewschoen
ceph-volume: adds a lvs property to the Device class
02c9a02 
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
(cherry picked from commit 3dae324)
@andrewschoen
ceph-volume: adds a used_by_ceph property to the Device class
950f6e1 
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
(cherry picked from commit 9d49a37)
@andrewschoen
ceph-volume: adds used_by_ceph to filestore singletype batch report
001cd83 
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
(cherry picked from commit 48d10c9)
@andrewschoen
ceph-volume: adds a 'changed' key to lvm batch --report
d9026b4 
This will indicate if the command would result in any OSDs being created
or not. Other tooling can use that key for idempotency checks.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
(cherry picked from commit 10f1d57)
@andrewschoen
ceph-volume: pick strategy for batch with only the unused devices
556f7d0 
This will pick a strategy, filter out any devices already been used by
ceph and then pick a strategy again. If the strategy has changed the
call should error, if the strategy is the same proceed. If there are no
unused devices then the command is a noop.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
(cherry picked from commit 4529f2d)
@andrewschoen
ceph-volume: add filtered_devices and used_by_ceph to all batch reports
8c01c3d 
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
(cherry picked from commit 0718d2e)
@andrewschoen
ceph-volume: consider block and data devices used_by_ceph
1ac9d13 
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
(cherry picked from commit 6751253)
@andrewschoen
ceph-volume: update tests to account for filtered_devices in batch
245146d 
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
(cherry picked from commit 3639622)
@andrewschoen
ceph-volume: add tests for util.device.Device.used_by_ceph
5dc3af3 
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
(cherry picked from commit a28e653)
@andrewschoen
ceph-volume: add functional tests to ensure lvm batch is idempotent
9f3c924 
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
(cherry picked from commit 9752d03)
@andrewschoen
ceph-volume: raise a non zero exit code if strategy changes with batch
ff13330 
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
(cherry picked from commit 9dfc00f)
@andrewschoen
ceph-volume: fix strategy comparison in 'lvm batch'
4f115f5 
This also fixes some small json reporting issues with the
filestore MixedType strategy

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
(cherry picked from commit 1dd1502)
@andrewschoen
ceph-volume: ignore failure to load ceph configuration for block.db size
8ecbecd 
If we fail to load a ceph configureation file when trying to get the
block.db size then just use defaults instead of throwing an error.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
(cherry picked from commit a7ee36c)
@andrewschoen
ceph-volume: fix bluestore strategy json reporting and type
b010327 
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
(cherry picked from commit b3cf906)
@andrewschoen
ceph-volume: fix idempotency checks for lvm batch tests
900156a 
The mixed type tests will change strategy after the idempotency test so
we need to handle that in test playbook.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
(cherry picked from commit 1143482)
@andrewschoen
ceph-volume: remove the used_by_ceph key in the json output
30887b0 
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
(cherry picked from commit 3b6d82a)
@andrewschoen
ceph-volume: add info about filtered devices to batch pretty reports
770454e 
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
(cherry picked from commit 62426db)
@andrewschoen
ceph-volume: add rotational property to Device class
325191b 
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
(cherry picked from commit 7f6bfaa)
@andrewschoen
ceph-volume: filter devices used by journals/block.db
c06e3cb 
If after filterering of data/block devices there are only
one device left it can not be used if it is an SSD and
has been used previously as a journal or block.db

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
(cherry picked from commit fc9a10e)
@andrewschoen
ceph-volume: when all devices are filtered exit gracefully
456c073 
Even if all devices are filtered we want to return a 0 exit code and
make sure the json reporting still works.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
(cherry picked from commit aa4fcd6)
@andrewschoen
ceph-volume: failing to get block db size from conf logs an exception
3722ad6 
Signed-off-by: Andrew Schoen <aschoen@redhat.com>
(cherry picked from commit 172d4af)
@andrewschoen
ceph-volume: extracts batch.filter_devices from Batch._get_strategy
558bccd 
This allows us to easily provide tests for that method.

Signed-off-by: Andrew Schoen <aschoen@redhat.com>
(cherry picked from commit df7ef53)
@ceph-jenkins ceph-jenkins added this to the mimic milestone Oct 15, 2018
@alfredodeza
Copy link
Contributor

jenkins test ceph-volume lvm

@alfredodeza
Copy link
Contributor

jenkins test ceph-volume batch

@andrewschoen
Copy link
Contributor Author

jenkins test ceph-volume batch all

@andrewschoen
Copy link
Contributor Author

jenkins test ceph-volume lvm all

@andrewschoen
Copy link
Contributor Author

jenkins test ceph-volume tox

@alfredodeza alfredodeza merged commit c41a8ac into mimic Oct 24, 2018
@alfredodeza alfredodeza deleted the backport-mimic-24404 branch October 24, 2018 21:23
@andrewschoen andrewschoen mentioned this pull request Oct 31, 2018
Closed
@andrewschoen andrewschoen mentioned this pull request Nov 28, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alfredodeza alfredodeza Awaiting requested review from alfredodeza

Assignees
No one assigned
Labels
ceph-volume
Projects
None yet
Milestone
mimic
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewschoen @alfredodeza @ceph-jenkins