-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
luminous: ceph-volume: make lvm batch
idempotent
#24589
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Schoen <aschoen@redhat.com> (cherry picked from commit 619810c)
Signed-off-by: Andrew Schoen <aschoen@redhat.com> (cherry picked from commit 3dae324)
Signed-off-by: Andrew Schoen <aschoen@redhat.com> (cherry picked from commit 9d49a37)
Signed-off-by: Andrew Schoen <aschoen@redhat.com> (cherry picked from commit 48d10c9)
This will indicate if the command would result in any OSDs being created or not. Other tooling can use that key for idempotency checks. Signed-off-by: Andrew Schoen <aschoen@redhat.com> (cherry picked from commit 10f1d57)
This will pick a strategy, filter out any devices already been used by ceph and then pick a strategy again. If the strategy has changed the call should error, if the strategy is the same proceed. If there are no unused devices then the command is a noop. Signed-off-by: Andrew Schoen <aschoen@redhat.com> (cherry picked from commit 4529f2d)
Signed-off-by: Andrew Schoen <aschoen@redhat.com> (cherry picked from commit 0718d2e)
Signed-off-by: Andrew Schoen <aschoen@redhat.com> (cherry picked from commit 6751253)
Signed-off-by: Andrew Schoen <aschoen@redhat.com> (cherry picked from commit 3639622)
Signed-off-by: Andrew Schoen <aschoen@redhat.com> (cherry picked from commit a28e653)
Signed-off-by: Andrew Schoen <aschoen@redhat.com> (cherry picked from commit 9752d03)
Signed-off-by: Andrew Schoen <aschoen@redhat.com> (cherry picked from commit 9dfc00f)
This also fixes some small json reporting issues with the filestore MixedType strategy Signed-off-by: Andrew Schoen <aschoen@redhat.com> (cherry picked from commit 1dd1502)
If we fail to load a ceph configureation file when trying to get the block.db size then just use defaults instead of throwing an error. Signed-off-by: Andrew Schoen <aschoen@redhat.com> (cherry picked from commit a7ee36c)
Signed-off-by: Andrew Schoen <aschoen@redhat.com> (cherry picked from commit b3cf906)
The mixed type tests will change strategy after the idempotency test so we need to handle that in test playbook. Signed-off-by: Andrew Schoen <aschoen@redhat.com> (cherry picked from commit 1143482)
Signed-off-by: Andrew Schoen <aschoen@redhat.com> (cherry picked from commit 3b6d82a)
Signed-off-by: Andrew Schoen <aschoen@redhat.com> (cherry picked from commit 62426db)
Signed-off-by: Andrew Schoen <aschoen@redhat.com> (cherry picked from commit 7f6bfaa)
If after filterering of data/block devices there are only one device left it can not be used if it is an SSD and has been used previously as a journal or block.db Signed-off-by: Andrew Schoen <aschoen@redhat.com> (cherry picked from commit fc9a10e)
Even if all devices are filtered we want to return a 0 exit code and make sure the json reporting still works. Signed-off-by: Andrew Schoen <aschoen@redhat.com> (cherry picked from commit aa4fcd6)
Signed-off-by: Andrew Schoen <aschoen@redhat.com> (cherry picked from commit 172d4af)
This allows us to easily provide tests for that method. Signed-off-by: Andrew Schoen <aschoen@redhat.com> (cherry picked from commit df7ef53)
jenkins test ceph-volume tox |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #24404