Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common/Throttle: TokenBucketThrottle: use reference to m_blockers.front() #24604

Merged
merged 1 commit into from
Oct 18, 2018

Conversation

yangdongsheng
Copy link
Contributor

…ate it

As we need to update the blocker below, then we need to use reference to front object,
rather than a new object of blocker.

Signed-off-by: Dongsheng Yang dongsheng.yang@easystack.cn

Copy link

@dillaman dillaman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dillaman
Copy link

@yangdongsheng Can you open a tracker ticket and add the Fixes line to the commit? I would like to get this in Mimic as well.

…ate it

As we need to update the blocker below, then we need to use reference to front object,
rather than a new object of blocker.

Fixes: http://tracker.ceph.com/issues/36475
Signed-off-by: Dongsheng Yang <dongsheng.yang@easystack.cn>
@yangdongsheng
Copy link
Contributor Author

@dillaman Done:

Fixes: http://tracker.ceph.com/issues/36475

@liewegas liewegas changed the title TokenBucketThrottle: use reference to m_blockers.front() and then upd… common/Throttle: TokenBucketThrottle: use reference to m_blockers.front() and then upd… Oct 17, 2018
@liewegas liewegas changed the title common/Throttle: TokenBucketThrottle: use reference to m_blockers.front() and then upd… common/Throttle: TokenBucketThrottle: use reference to m_blockers.front() Oct 17, 2018
@dillaman dillaman merged commit f3c843c into ceph:master Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants