Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mds: handle state change race #24797

Merged
merged 1 commit into from
Dec 22, 2018
Merged

Conversation

ukernel
Copy link
Contributor

@ukernel ukernel commented Oct 29, 2018

In multi-mds cluster, recovering mds may receive mdsmap that changes
its state after other mds. Furthermore, the recovering mds may receive
messages tiggered by its state change from other mds before it receive
corresponding mdsmap.

Fixes: http://tracker.ceph.com/issues/37594

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

@ukernel ukernel added bug-fix cephfs Ceph File System labels Oct 29, 2018
Copy link
Member

@batrick batrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain the race that you found in the commit message and in comments? This needs a tracker issue too.

@batrick
Copy link
Member

batrick commented Nov 29, 2018

@ukernel ping, tracker ticket?

In multi-mds cluster, recovering mds may receive mdsmap that changes
its state after other mds. Furthermore, the recovering mds may receive
messages tiggered by its state change from other mds before it receive
corresponding mdsmap.

Fixes: http://tracker.ceph.com/issues/37594
Signed-off-by: "Yan, Zheng" <zyan@redhat.com>
@batrick
Copy link
Member

batrick commented Dec 22, 2018

retest this please

@batrick batrick merged commit d3a4444 into ceph:master Dec 22, 2018
batrick added a commit that referenced this pull request Dec 22, 2018
* refs/pull/24797/head:
	mds: handle state change race

Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
@ukernel ukernel deleted the wip-mds-state-race branch November 13, 2019 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants