cmake: do not pass -B{symbolic,symbolic-functions} to linker on FreeBSD #24920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjwithagen
added
bug-fix
build/ops
backport
FreeBSD
tchaikov
approved these changes
Nov 5, 2018
tchaikov
changed the title
|
@wjwithagen the fix is not related to symbolic link. it's more about symbol resolution. so i updated the title of this PR accordingly. could you update your the title of your commit also? see also https://sourceware.org/binutils/docs-2.16/ld/Options.html#Options |
Signed-off-by: Willem Jan Withagen <wjw@digiware.nl>
wjwithagen
force-pushed
the
wjw-fix-build-symbolic
branch
from
ec62d3d
to
60c6e70
Compare
|
@tchaikov |
|
@tchaikov |
|
@wjwithagen probably you could go ahead and just file a PR cherry-picking this change ? but i guess a better way would be to file a tracker ticket for this issue. what do you think? |
|
@tchaikov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the -Wl flags, this will result in a crashing ceph-mon
on FreeBSD. very likely because the FreeBSD linker is no longer the
GNU linker.
This also needs to be backported to mimic.