os/bluestore: fix wal dir presence verification #24948
Conversation
Fixes: http://tracker.ceph.com/issues/36606 Signed-off-by: Igor Fedotov <ifedotov@suse.com>
|
@neha-ojha - could you please give this fix a QA run? |
|
@ifed01 You just need to add the needs-qa label and it will get picked up by the next person to run a batch through qa. |
|
@liewegas - It seems this has been caught by some specific test case, not sure it's covered by the regular run. |
|
yeah, the issue reliably reproduces in the fs suite with a specific filter. http://tracker.ceph.com/issues/36606#note-9 @liewegas I can run the test once the build for |
|
Running the test with this fix: http://pulpito.ceph.com/nojha-2018-11-07_17:44:20-fs:upgrade-wip-sage3-testing-2018-11-06-0907-distro-basic-smithi/ |
|
@ifed01 @liewegas the test passed #24948 (comment) |
|
@ifed01 This should be backported, right? |
* refs/pull/24948/head: os/bluestore: fix wal dir presence verification Reviewed-by: Sage Weil <sage@redhat.com>
|
@liewegas - no, it's specific to Nautilus for now. We need it when/if we backport BlueFS migrate stuff. |
BlueStore verified wrong status code and hence didn't clean "separate_wal_dir" option for legacy deployments.
Fixes: http://tracker.ceph.com/issues/36606
Signed-off-by: Igor Fedotov ifedotov@suse.com