mimic: rgw-admin: reshard add can add a non existant bucket #25087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the method that validates the reshard params does not fail correctly in case of a non existant bucket causing reshard add to print an error message but add the non existant bucket to the queue anyway. This will later be a cause of EBUSY errors as this entry on the logshard can never be processed. Fixes: http://tracker.ceph.com/issues/36449 Signed-off-by: Abhishek Lekshmanan <abhishek@suse.com> (cherry picked from commit c564b34) Signed-off-by: Jonathan Brielmaier <jbrielmaier@suse.de>
cbodley
approved these changes
Nov 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/36756