Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mgr/dashboard: Fix run-frontend-e2e-tests.sh #25157

Merged
merged 1 commit into from
Nov 21, 2018
Merged

Conversation

tspmelo
Copy link
Contributor

@tspmelo tspmelo commented Nov 19, 2018

e2e tests were always returning positive result, even when they failed.

Fixed problem with jq, where it was failing when it was not receiving a string.

Signed-off-by: Tiago Melo <tmelo@suse.com>

@tspmelo tspmelo changed the title mgr/dashboard: Fix run-frontend-e2e-tests-sh mgr/dashboard: Fix run-frontend-e2e-tests.sh Nov 19, 2018
e2e tests were always returning positive result, even when they failed.

Fixed problem with jq, where it was failing when it was not receiving a string.

Signed-off-by: Tiago Melo <tmelo@suse.com>
Copy link
Member

@callithea callithea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me! :)

@LenzGr LenzGr merged commit 11c61fc into ceph:master Nov 21, 2018
@tspmelo tspmelo deleted the wip-e2e-stop branch November 21, 2018 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants