Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mgr/dashboard: Add i18n validation script #25179

Merged
merged 1 commit into from Nov 28, 2018
Merged

mgr/dashboard: Add i18n validation script #25179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/pybind/mgr/dashboard/HACKING.rst
View file
Open in desktop
Expand Up @@ -249,6 +249,10 @@ parse the TypeScript files.
When the command ran successfully, it should have created or updated the file
``src/locale/messages.xlf``.

To make sure this file is always up to date in master branch, we added a
validation in ``run-frontend-unittests.sh`` that will fail if it finds
uncommitted translations.

Supported languages
~~~~~~~~~~~~~~~~~~~

Expand Down
4 changes: 1 addition & 3 deletions src/pybind/mgr/dashboard/frontend/src/app/ceph/cluster/osd/osd-list/osd-list.component.html
View file
Open in desktop
Expand Up @@ -71,9 +71,7 @@
let-actionDescription="actionDescription">
<div *ngIf="!safeToDestroyResult['is_safe_to_destroy']"
class="danger">
<cd-warning-panel i18n>
The OSD is not safe to destroy!
</cd-warning-panel>
<cd-warning-panel i18n>The OSD is not safe to destroy!</cd-warning-panel>
</div>
<ng-container i18n><strong>OSD {{ selection.first().id }}</strong> will be
<strong>{{ actionDescription }}</strong> if you proceed.</ng-container>
Expand Down
3 changes: 1 addition & 2 deletions ...ybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.html
View file
Open in desktop
Expand Up @@ -88,8 +88,7 @@
*ngIf="permissions.log.read">
<a i18n
class="dropdown-item"
routerLink="/logs">Logs
</a>
routerLink="/logs">Logs</a>
</li>
</ul>
</li>
Expand Down