mgr/dashboard: Add i18n validation script #25179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tspmelo
force-pushed
the
wip-check-i18n
branch
from
5c83f8a
to
e6e302f
Compare
callithea
reviewed
Nov 22, 2018
tspmelo
force-pushed
the
wip-check-i18n
branch
from
e6e302f
to
bb4329b
Compare
callithea
approved these changes
Nov 22, 2018
LenzGr
reviewed
Nov 22, 2018
LenzGr
reviewed
Nov 22, 2018
LenzGr
reviewed
Nov 22, 2018
| count=`git status | grep "messages.xlf" -c` | ||
|
|
||
| if [ $count == 1 ]; then | ||
| echo "Please run 'npm run i18n' and commit the modified 'messages.xlf' file." |
There was a problem hiding this comment.
At this point npm run i18n has already been run and messages.xlf is up to date, isn't it?
Suggested change
| echo "Please run 'npm run i18n' and commit the modified 'messages.xlf' file." | |
| echo "The translation template file 'messages.xlf' has been modified. Please commit the changes." |
There was a problem hiding this comment.
This script is more focused in being used in jenkins, so this message is going to be read after a failing ceph dashboard tests. Then the developer will need to run the script locally.
LenzGr
reviewed
Nov 22, 2018
tspmelo
force-pushed
the
wip-check-i18n
branch
from
bb4329b
to
4c23bab
Compare
|
I moved the validation to the existing |
tspmelo
force-pushed
the
wip-check-i18n
branch
from
4c23bab
to
613d6b0
Compare
|
@p-na I added a new validation to |
p-se
approved these changes
Nov 23, 2018
tspmelo
force-pushed
the
wip-check-i18n
branch
from
613d6b0
to
9aad8a3
Compare
tspmelo
force-pushed
the
wip-check-i18n
branch
from
9aad8a3
to
9d25d6a
Compare
|
retest this please |
tspmelo
force-pushed
the
wip-check-i18n
branch
from
9d25d6a
to
00133c2
Compare
This will check if there are new strings, validate them and ask the developer to commit and fix those. Signed-off-by: Tiago Melo <tmelo@suse.com>
tspmelo
force-pushed
the
wip-check-i18n
branch
from
00133c2
to
091bd4b
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will check if there are new strings and ask the developer to commit those.
Signed-off-by: Tiago Melo <tmelo@suse.com>