do_cmake: warn users about slow debug builds #25478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdurgin
approved these changes
Dec 11, 2018
tchaikov
reviewed
Dec 11, 2018
markhpc
force-pushed
the
wip-do_cmake-warn
branch
from
6382e66
to
930fa1c
Compare
added 3 commits
December 12, 2018 12:09
Signed-off-by: Mark Nelson <mnelson@redhat.com>
Signed-off-by: Mark Nelson <mnelson@redhat.com>
Signed-off-by: Mark Nelson <mnelson@redhat.com>
markhpc
force-pushed
the
wip-do_cmake-warn
branch
from
930fa1c
to
3214b71
Compare
liewegas
approved these changes
Dec 13, 2018
liewegas
added a commit
that referenced
this pull request
Dec 13, 2018
* refs/pull/25478/head: README.md: Add note about default do_cmake.sh debug builds. doc/install: Add note about default do_cmake.sh debug builds. do_cmake: Warn user about slow debug performance by default. Reviewed-by: Kefu Chai <kchai@redhat.com> Reviewed-by: Josh Durgin <jdurgin@redhat.com> Reviewed-by: Sage Weil <sage@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spent more time than I want to admit bisecting master over the weekend looking for a 5X random write performance regression on NVMe. Finally I figured out that do_cmake.sh was changed to create debug builds by default in #24133. 馃槄 This PR adds copious warnings so that I hopefully won't have to bisect this again in six months after I've forgotten that we changed the default behavior.