Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: mds: disallow dumping huge caches to formatter #25642

Merged
merged 1 commit into from Jan 30, 2019

Conversation

Projects
None yet
3 participants
@vshankar
Copy link
Contributor

commented Dec 20, 2018

@vshankar vshankar added the cephfs label Dec 20, 2018

@vshankar vshankar added this to the mimic milestone Dec 20, 2018

@vshankar vshankar requested review from batrick and smithfarm Dec 20, 2018

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Jan 17, 2019

@vshankar Please rebase?

@vshankar

This comment has been minimized.

Copy link
Contributor Author

commented Jan 21, 2019

@vshankar Please rebase?

will do.

mds: disallow dumping huge caches to formatter
Dumping huge caches (~ 1G) to formatter causes mds to
hang or get terminated. Until the underlying issues is
fixed, disallow dumping cache if cache usage exceeds this
threshold. Also, Patrick feels a similar issue might be
hiding there for cache dumps to file when cache sizes
are really huge. This case has not been been reproduced
yet, hence, the limit for cache dumps to file is currently
kept not capped.

Fixes: http://tracker.ceph.com/issues/37609
Signed-off-by: Venky Shankar <vshankar@redhat.com>
(cherry picked from commit 6be2ce9)

 Conflicts:
	src/common/options.cc
	src/mds/MDCache.cc

Minor fix for fetching config option with g_conf.

@vshankar vshankar force-pushed the vshankar:wip-37609 branch from 37125ce to d6c8aec Jan 22, 2019

@vshankar vshankar removed the needs-rebase label Jan 22, 2019

@vshankar

This comment has been minimized.

Copy link
Contributor Author

commented Jan 22, 2019

@smithfarm rebased and updated

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Jan 25, 2019

@vshankar

This comment has been minimized.

Copy link
Contributor Author

commented Jan 30, 2019

Reviewed-by: Venky Shankar vshankar@redhat.com

@yuriw

yuriw approved these changes Jan 30, 2019

Copy link
Contributor

left a comment

Reviewed-by:  Venky Shankar vshankar@redhat.com

@yuriw yuriw merged commit f25113f into ceph:mimic Jan 30, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.