mimic: mds: disallow dumping huge caches to formatter #25642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vshankar Please rebase? |
will do. |
Dumping huge caches (~ 1G) to formatter causes mds to hang or get terminated. Until the underlying issues is fixed, disallow dumping cache if cache usage exceeds this threshold. Also, Patrick feels a similar issue might be hiding there for cache dumps to file when cache sizes are really huge. This case has not been been reproduced yet, hence, the limit for cache dumps to file is currently kept not capped. Fixes: http://tracker.ceph.com/issues/37609 Signed-off-by: Venky Shankar <vshankar@redhat.com> (cherry picked from commit 6be2ce9) Conflicts: src/common/options.cc src/mds/MDCache.cc Minor fix for fetching config option with g_conf.
|
@smithfarm rebased and updated |
|
Reviewed-by: Venky Shankar vshankar@redhat.com |
yuriw
approved these changes
Jan 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/37609