mgr/dashboard: upgraded python dev dependencies #26007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfonsomthd
requested review from
LenzGr,
votdev,
sebastian-philipp,
s0nea,
p-se,
ricardoasmarques,
Devp00l,
rjfd,
callithea and
epuertat
|
Thank you for taking care of this, @alfonsomthd! Would you mind splitting this PR into two separate commits? I think it would make sense to have one that updates the versions and configuration of our environment, and then a separate cleanup commit that addresses all of the things that have been reported. |
* pylint, astroid: upgraded only for python 3. Latest stable, compatible even with python 3.7 * pycodestyle: 2.4.0 latest stable (python 2 & 3) Signed-off-by: Alfonso Martínez <almartin@redhat.com>
* Fixed linting/style issues found after upgrading: pylint, astroid, pycodestyle Signed-off-by: Alfonso Martínez <almartin@redhat.com>
alfonsomthd
force-pushed
the
upgrade-python-dev-deps
branch
from
87d9688
to
f56d2f6
Compare
|
@LenzGr Sure. Done. |
epuertat
approved these changes
Jan 17, 2019
| @@ -832,6 +832,7 @@ def getargspec(func): | |||
| func = func.__wrapped__ | |||
| except AttributeError: | |||
| pass | |||
| # pylint: disable=deprecated-method | |||
There was a problem hiding this comment.
How pluggy devs dealt with this...
There was a problem hiding this comment.
we're very likely going full Python 3 by the end of the year. I'd be ok with a pylint for the moment.
callithea
approved these changes
Jan 21, 2019
p-se
approved these changes
Jan 22, 2019
sebastian-philipp
approved these changes
Jan 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pylint, astroid: upgraded only for python 3.
Latest stable, compatible even with python 3.7
pycodestyle: 2.4.0 latest stable (python 2 & 3)
Fixed linting/style issues found after upgrade.
Fixes: https://tracker.ceph.com/issues/37385
Signed-off-by: Alfonso Martínez almartin@redhat.com