mgr/rook: remove dead code and fix bug in url fetching code #26032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
John evidently added this code early on in development, when we figured we might be taking over a cluster that is already running under k8s. I don't see how we'd ever make that work, so just remove this function for now, and the commented-out callsite. Reported-by: Sebastian Wagner <sebastian.wagner@suse.com> Signed-off-by: Jeff Layton <jlayton@redhat.com>
sebastian-philipp
approved these changes
Jan 18, 2019
|
found by #26028 |
It's possible for the fetch of this object to fail if the service is being torn down. Handle that situation gracefully, but log a message. Signed-off-by: Jeff Layton <jlayton@redhat.com>
jtlayton
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This deletes some dead code in the rook module, and also adds handling in "service ls" for the case where the cephnfs object is no longer present but the pod is.