rgw: Replace COMPLETE_MULTIPART_MAX_LEN with rgw_max_put_param_size #26070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cbodley PTAL |
cbodley
reviewed
Jan 29, 2019
src/rgw/rgw_rest.cc
Outdated
| #define COMPLETE_MULTIPART_MAX_LEN (1024 * 1024) /* api defines max 10,000 parts, this should be enough */ | ||
| std::tie(op_ret, data) = rgw_rest_read_all_input(s, COMPLETE_MULTIPART_MAX_LEN); | ||
| const auto max_size = s->cct->_conf->rgw_max_put_param_size; | ||
| std::tie(op_ret, data) = rgw_rest_read_all_input(s, max_size, false); |
There was a problem hiding this comment.
ok. 1M is also the default for rgw_max_put_param_size, but it does make sense to allow configuration
but why change allow_chunked to false? especially when you expect large requests?
…_param_size Fixes: http://tracker.ceph.com/issues/38002 Signed-off-by: Lei Liu <liul.stone@gmail.com>
|
Probably a comment in the options.cc will also help that this param controls the final complete multipart max len as well |
ivancich
added a commit
to ceph/ceph-ci
that referenced
this pull request
Mar 22, 2019
Merge branch 'fix-bug-38002' of https://github.com/iliul/ceph into wip-eric-testing-1
|
wip-eric-testing-1: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace COMPLETE_MULTIPART_MAX_LEN with configurable rgw_max_put_param_size
Fixes: http://tracker.ceph.com/issues/38002
Signed-off-by: Lei Liu liul.stone@gmail.com