Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: multisite: bucket full sync does not handle delete markers #26194

Merged
merged 6 commits into from May 3, 2019

Conversation

Projects
None yet
5 participants
@pdvian
Copy link

commented Jan 30, 2019

cbodley added some commits May 22, 2018

test/rgw: check_bucket_eq() supports delete markers
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 305f6dd)
test/rgw: check_bucket_eq() uses bucket.list_versions()
get_all_versions() is documented as a lower-level api that doesn't
handle paging, ands suggests list_versions() instead. also caches the
results to avoid listing each bucket twice

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 22d1da7)
test/rgw: use version_id from key directly
now that PutObj returns the x-amz-version-id, it's available through
Key.version_id without resorting to Bucket.list_versions()

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 4d2cf73)
test/rgw: add multisite test_delete_marker_full_sync()
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit fba4ed7)

Conflicts:
	src/test/rgw/rgw_multi/tests.py : Added test_delete_marker_full_sync
test/rgw: add multisite test_suspended_delete_marker_full_sync()
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 8686b64)
rgw: bucket full sync handles delete markers
full sync uses CLS_RGW_OP_LINK_OLH_DM for delete markers instead of
trying to fetch them from the source zone

Fixes: http://tracker.ceph.com/issues/38007

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 5ffd34c)

@tchaikov tchaikov added this to the mimic milestone Jan 30, 2019

@smithfarm smithfarm requested a review from cbodley Jan 30, 2019

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Feb 5, 2019

@yuriw

This comment has been minimized.

Copy link
Contributor

commented Feb 18, 2019

@pdvian @cbodley add tags when ready

@yuriw yuriw added the rgw label Feb 18, 2019

@cbodley cbodley self-assigned this Feb 19, 2019

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Mar 1, 2019

@cbodley @yuriw Did this cause tests to fail? And, if so, which ones?

@cbodley

This comment has been minimized.

Copy link
Contributor

commented Mar 1, 2019

this failed its own test_suspended_delete_marker_full_sync. there are some more related fixes in wip-yuri6-testing, so i'd like to try this one again after those merge

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

@cbodley @yuriw Any update on the wip-yuri6-testing run ?

@smithfarm

This comment has been minimized.

Copy link
Contributor

commented May 1, 2019

@cbodley It looks to me like those PRs you referred to have all been merged, so I'm returning this into the pool to mimic PRs to be tested.

@yuriw

This comment has been minimized.

Copy link
Contributor

commented May 2, 2019

@yuriw yuriw merged commit 186e1d9 into ceph:mimic May 3, 2019

4 checks passed

Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.