Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mimic: multisite: bucket full sync does not handle delete markers #26194

Merged
merged 6 commits into from
May 3, 2019
Merged

mimic: multisite: bucket full sync does not handle delete markers #26194

merged 6 commits into from
May 3, 2019

Conversation

pdvian
Copy link

@pdvian pdvian commented Jan 30, 2019

@cbodley
test/rgw: check_bucket_eq() uses bucket.list_versions()
ce26734 
get_all_versions() is documented as a lower-level api that doesn't
handle paging, ands suggests list_versions() instead. also caches the
results to avoid listing each bucket twice

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 22d1da7)
@cbodley
test/rgw: check_bucket_eq() supports delete markers
1d3005a 
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 305f6dd)
@cbodley
test/rgw: use version_id from key directly
27ad100 
now that PutObj returns the x-amz-version-id, it's available through
Key.version_id without resorting to Bucket.list_versions()

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 4d2cf73)
@cbodley
test/rgw: add multisite test_delete_marker_full_sync()
2d5ee7a 
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit fba4ed7)

Conflicts:
	src/test/rgw/rgw_multi/tests.py : Added test_delete_marker_full_sync
@cbodley
test/rgw: add multisite test_suspended_delete_marker_full_sync()
05277c8 
Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 8686b64)
@cbodley
rgw: bucket full sync handles delete markers
73d4d5f 
full sync uses CLS_RGW_OP_LINK_OLH_DM for delete markers instead of
trying to fetch them from the source zone

Fixes: http://tracker.ceph.com/issues/38007

Signed-off-by: Casey Bodley <cbodley@redhat.com>
(cherry picked from commit 5ffd34c)
@tchaikov tchaikov added this to the mimic milestone Jan 30, 2019
@yuriw
Copy link
Contributor

yuriw commented Feb 5, 2019

wip-yuri5-testing-2019-02-05-1730-mimic

@yuriw
Copy link
Contributor

yuriw commented Feb 18, 2019

@pdvian @cbodley add tags when ready

@yuriw yuriw added the rgw label Feb 18, 2019
@cbodley cbodley self-assigned this Feb 19, 2019
@smithfarm
Copy link
Contributor

@cbodley @yuriw Did this cause tests to fail? And, if so, which ones?

@cbodley
Copy link
Contributor

cbodley commented Mar 1, 2019

this failed its own test_suspended_delete_marker_full_sync. there are some more related fixes in wip-yuri6-testing, so i'd like to try this one again after those merge

@smithfarm
Copy link
Contributor

@cbodley @yuriw Any update on the wip-yuri6-testing run ?

@smithfarm
Copy link
Contributor

@cbodley It looks to me like those PRs you referred to have all been merged, so I'm returning this into the pool to mimic PRs to be tested.

@yuriw
Copy link
Contributor

yuriw commented May 2, 2019

wip-yuri2-testing-2019-05-02-2259-mimic

@yuriw yuriw merged commit 186e1d9 into ceph:mimic May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbodley cbodley cbodley approved these changes

Assignees

@cbodley cbodley

Labels
mimic-batch-1 needs-qa rgw tests wip-yuri2-testing
Projects
None yet
Milestone
mimic
Development

Successfully merging this pull request may close these issues.
5 participants
@pdvian @yuriw @smithfarm @cbodley @tchaikov