Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common: drop the unused methods from SharedLRU. #26224

Merged
merged 2 commits into from
Feb 1, 2019
Merged

common: drop the unused methods from SharedLRU. #26224

merged 2 commits into from
Feb 1, 2019

Conversation

tchaikov
Copy link
Contributor

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

@rzarzynski @tchaikov
common: drop the unused get_comparator() from SharedLRU.
b701f8f 
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
@rzarzynski @tchaikov
common: drop the unused reset_comparator() from SharedLRU.
4234101 
Signed-off-by: Radoslaw Zarzynski <rzarzyns@redhat.com>
@tchaikov tchaikov mentioned this pull request Jan 31, 2019
Closed
@tchaikov
Copy link
Contributor Author

@rzarzynski the change looks good to me.

rzarzynski
rzarzynski reviewed Jan 31, 2019
View reviewed changes
Copy link
Contributor

@rzarzynski rzarzynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dissection from the bigger PR looks fine.

@tchaikov
Copy link
Contributor Author

tchaikov commented Feb 1, 2019

https://shaman.ceph.com/builds/ceph/wip-kefu2-testing-2019-02-01-2130/471ca950ef556d0a53c3110916eec58d48dfe79e/

@tchaikov tchaikov merged commit e124ad7 into ceph:master Feb 1, 2019
@tchaikov tchaikov deleted the radek-lru-cleanup branch February 1, 2019 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rzarzynski rzarzynski rzarzynski approved these changes

@neha-ojha neha-ojha Awaiting requested review from neha-ojha

Assignees
No one assigned
Labels
cleanup common needs-qa
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tchaikov @rzarzynski