tools/ceph_kvstore_tool: Move summary output to print_summary #26666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
approved these changes
Feb 27, 2019
src/tools/kvstore_tool.cc
Outdated
| @@ -179,6 +179,19 @@ bool StoreTool::rm_prefix(const string& prefix) | |||
| return (ret == 0); | |||
| } | |||
|
|
|||
| void StoreTool::print_summary(const uint64_t total_keys, const uint64_t total_size, | |||
| const uint64_t total_txs, const string &store_path, | |||
| const string &other_path, const int duration) const | |||
There was a problem hiding this comment.
nit, might want to put & right next to string. as it's part of type.
src/tools/kvstore_tool.h
Outdated
| @@ -62,6 +62,9 @@ class StoreTool | |||
| ceph::bufferlist& val); | |||
| bool rm(const std::string& prefix, const std::string& key); | |||
| bool rm_prefix(const std::string& prefix); | |||
| void print_summary(const uint64_t total_keys, const uint64_t total_size, | |||
| const uint64_t total_txs, const string &store_path, | |||
There was a problem hiding this comment.
Bah! Must be a clang-format thing... using LLVM style...
badone
force-pushed
the
wip-kvstore_tool-ice
branch
from
f504546
to
7935cf8
Compare
tchaikov
reviewed
Feb 27, 2019
src/tools/kvstore_tool.h
Outdated
| @@ -62,6 +62,9 @@ class StoreTool | |||
| ceph::bufferlist& val); | |||
| bool rm(const std::string& prefix, const std::string& key); | |||
| bool rm_prefix(const std::string& prefix); | |||
| void print_summary(const uint64_t total_keys, const uint64_t total_size, | |||
| const uint64_t total_txs, const string& store_path, | |||
There was a problem hiding this comment.
s/string/std::string/
we'd better not relying on using namespace std or using std::string somewhere else.
Post 301a642 we are still seeing an ICE in the copy_store_to code. Moving the summary printing to its own function alleviates the issue. Signed-off-by: Brad Hubbard <bhubbard@redhat.com>
badone
force-pushed
the
wip-kvstore_tool-ice
branch
from
7935cf8
to
504ab05
Compare
3 tasks
xiexingguo
approved these changes
Mar 1, 2019
|
It would be much appreciated if we can get this patch merged ASAP. |
|
Testing it now. |
|
Seems like the testing queue has stalled. I'll check it in the morning APAC time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Post 301a642 we are still seeing an ICE
in the copy_store_to code. Moving the summary printing to its own
function alleviates the issue.
Signed-off-by: Brad Hubbard bhubbard@redhat.com