Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luminous: mgr/dashboard: fix for using '::' on hosts without ipv6 #26751

Merged
merged 1 commit into from
Apr 1, 2019
Merged

luminous: mgr/dashboard: fix for using '::' on hosts without ipv6 #26751

merged 1 commit into from
Apr 1, 2019

Conversation

dotnwat
Copy link
Contributor

@dotnwat dotnwat commented Mar 4, 2019 •
edited by batrick
Loading

@dotnwat
mgr/dashboard: fix for using '::' on hosts without ipv6
4c4bf59 
CherryPy throws an uncaught exception using '::' when the host does not
have an ipv6 loopback address. This is currently the case in kubernetes.
This patch disables the routine in cherrypy that performs the validation
that requested server ports are actually bound.

fixes: http://tracker.ceph.com/issues/38576

Signed-off-by: Noah Watkins <noahwatkins@gmail.com>
(cherry picked from commit 384d82a)

Conflicts:
	src/pybind/mgr/dashboard/module.py

Contextual conflict as >luminous had nearby SSL code that was never
backported.
@batrick batrick changed the title mgr/dashboard: fix for using '::' on hosts without ipv6 luminous: mgr/dashboard: fix for using '::' on hosts without ipv6 Mar 4, 2019
@batrick batrick added this to the luminous milestone Mar 4, 2019
@dotnwat dotnwat mentioned this pull request Mar 4, 2019
Closed
@smithfarm
Copy link
Contributor

@noahdesu Thanks for backporting!

Please, next time, use the following procedure to create the backport tracker issues:

  1. create a master tracker pointing to the master PR containing the bugfix or feature to be backported.
  2. in the master tracker, set the Backport field so it contains the names of the stable releases the fix/feature should be backport to. E.g.: "mimic, luminous" (commas are optional)
  3. when the master PR merges, set the Status to "Pending Backport"
  4. if you are content to let the backporting team do the cherry-picking, then that's all - you're done.
  5. if you would like to cherry-pick yourself, then create the backport tracker issues by running the src/script/backport-create-issue script (see comments at the top of the script for how to run it)

The backport-create-issue script needs to know your Redmine username and password or, alternatively, your Redmine token. You can also pass it the number of the master tracker you want to create backport issues for.

Thanks again!

@smithfarm smithfarm removed the backport label Mar 5, 2019
@smithfarm smithfarm requested a review from LenzGr March 5, 2019 18:00
@dotnwat
Copy link
Contributor Author

dotnwat commented Mar 5, 2019

@smithfarm wow thanks for the explanation. i was attempting to reverse engineer other backports, and then i just discovered this http://docs.ceph.com/docs/master/dev/#backporting but your explanation here is much clearer.

@yuriw
Copy link
Contributor

yuriw commented Mar 20, 2019

wip-yuri2-testing-2019-03-20-2018-luminous

LenzGr
LenzGr approved these changes Mar 25, 2019
View reviewed changes
Copy link
Contributor

@LenzGr LenzGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@yuriw yuriw merged commit 98ac44d into ceph:luminous Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LenzGr LenzGr LenzGr approved these changes

@votdev votdev votdev approved these changes

Assignees
No one assigned
Labels
dashboard luminous-batch-1 mgr needs-qa wip-yuri2-testing
Projects
None yet
Milestone
luminous
Development

Successfully merging this pull request may close these issues.
8 participants
@dotnwat @smithfarm @yuriw @LenzGr @votdev @batrick @gregsfortytwo @callithea