Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: CLI: ability to change file ownership #26760

Merged
merged 1 commit into from
May 2, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions doc/man/8/ceph.rst
Original file line number Diff line number Diff line change
Expand Up @@ -1446,6 +1446,16 @@ Options
reply to outfile. Only specific monitor commands (e.g. osd getmap)
return a payload.

.. option:: --setuser user

will apply the appropriate user ownership to the file specified by
the option '-o'.

.. option:: --setgroup group

will apply the appropriate group ownership to the file specified by
the option '-o'.

.. option:: -c ceph.conf, --conf=ceph.conf

Use ceph.conf configuration file instead of the default
Expand Down
21 changes: 20 additions & 1 deletion src/ceph.in
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@ Foundation. See file COPYING.
from __future__ import print_function
from time import sleep
import codecs
import grp
import os
import pwd
import sys
import subprocess
import time
Expand Down Expand Up @@ -273,7 +275,10 @@ def parse_cmdargs(args=None, target=''):
help='input file, or "-" for stdin')
parser.add_argument('-o', '--out-file', dest='output_file',
help='output file, or "-" for stdout')

parser.add_argument('--setuser', dest='setuser',
help='set user file permission')
parser.add_argument('--setgroup', dest='setgroup',
help='set group file permission')
parser.add_argument('--id', '--user', dest='client_id',
help='client id for authentication')
parser.add_argument('--name', '-n', dest='client_name',
Expand Down Expand Up @@ -1086,6 +1091,20 @@ def main():
except Exception as e:
print('Can\'t open output file {0}: {1}'.format(parsed_args.output_file, e), file=sys.stderr)
return 1
if parsed_args.setuser:
try:
ownerid = pwd.getpwnam(parsed_args.setuser).pw_uid
os.fchown(outf.fileno(), ownerid, -1)
except OSError as e:
print('Failed to change user ownership of {0} to {1}: {2}'.format(outf, parsed_args.setuser, e))
return 1
if parsed_args.setgroup:
try:
groupid = grp.getgrnam(parsed_args.setgroup).gr_gid
os.fchown(outf.fileno(), -1, groupid)
except OSError as e:
print('Failed to change group ownership of {0} to {1}: {2}'.format(outf, parsed_args.setgroup, e))
return 1

# -s behaves like a command (ceph status).
if parsed_args.status:
Expand Down