rgw: Adding 'iam' namespace for Role and User Policy related REST APIs. #27178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pritha Srivastava <prsrivas@redhat.com>
adamemerson
approved these changes
Mar 26, 2019
|
|
||
| if (post_body.find("Action") != string::npos) { | ||
| boost::char_separator<char> sep("&"); | ||
| boost::tokenizer<boost::char_separator<char>> tokens(post_body, sep); |
There was a problem hiding this comment.
iirc boost::tokenizer isn't thought to be very efficient--maybe not a concern for now
There was a problem hiding this comment.
@adamemerson thoughts?
There was a problem hiding this comment.
@mattbenjamin @adamemerson @cbodley : I have the exact same method for parsing sts_input also, with a few differences. I could have made this into a common method that parses output for both. But later when we decide to have STS, IAM served at a different hostname:portname, then these methods will already be separate. Is this ok for now?
|
fine with me |
|
The teuthology run is here: http://pulpito.ceph.com/prsrivas-2019-04-12_08:57:26-rgw-wip-rgw-iam-distro-basic-smithi/ |
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pritha Srivastava prsrivas@redhat.com