Remove dependence on `using namespace`: Build of 'common' through osdc/Objecter.cc #27255

adamemerson · 2019-03-29T03:30:21Z

Go through a chunk of stuff removing the need for 'using namespace std' and 'using namespace ceph'.

Partial, of course, but getting Objecter.cc to compile means that the most commonly used headers used by targets in common should be cleaned up. Others are free to continue with further installments, if they wish.

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

tchaikov · 2019-04-01T04:22:11Z

retest this please.

tchaikov

lgtm in general aside from just a couple of nits/questions.

src/auth/AuthServiceHandler.h

tchaikov · 2019-04-01T04:26:21Z

src/auth/Crypto.h

@@ -1,4 +1,4 @@
-// -*- mode:C; tab-width:8; c-basic-offset:2; indent-tabs-mode:t -*-
+// -*- mode:C++; tab-width:8; c-basic-offset:2; indent-tabs-mode:t -*-


src/include/encoding.h

tchaikov · 2019-04-01T05:04:01Z

src/include/object.h

-#include <stdio.h>
-
+#include <cstdint>
+#include <cstdio>


tchaikov · 2019-04-02T11:31:05Z

http://pulpito.ceph.com/kchai-2019-04-01_10:38:29-rados-wip-kefu-testing-2019-04-01-1531-distro-basic-mira/

sebastian-philipp · 2019-05-23T13:19:53Z

Is https://jenkins.ceph.com/job/ceph-pull-requests/560/console related?

Failed to load class: cas (/home/jenkins-build/build/workspace/ceph-pull-requests/build/lib/libcls_cas.so): /home/jenkins-build/build/workspace/ceph-pull-requests/build/lib/libcls_cas.so: undefined symbol: cls_cxx_chunk_write_and_set(void*, int, int, ceph::buffer::v14_2_0::list*, unsigned int, ceph::buffer::v14_2_0::list*, int)
Failed to load class: cephfs (/home/jenkins-build/build/workspace/ceph-pull-requests/build/lib/libcls_cephfs.so): /home/jenkins-build/build/workspace/ceph-pull-requests/build/lib/libcls_cephfs.so: undefined symbol: typeinfo for PGLSFilter
Failed to load class: hello (/home/jenkins-build/build/workspace/ceph-pull-requests/build/lib/libcls_hello.so): /home/jenkins-build/build/workspace/ceph-pull-requests/build/lib/libcls_hello.so: undefined symbol: typeinfo for PGLSFilter
Failed to load class: log (/home/jenkins-build/build/workspace/ceph-pull-requests/build/lib/libcls_log.so): /home/jenkins-build/build/workspace/ceph-pull-requests/build/lib/libcls_log.so: undefined symbol: cls_cxx_map_read_header(void*, ceph::buffer::v14_2_0::list*)
Failed to load class: rgw (/home/jenkins-build/build/workspace/ceph-pull-requests/build/lib/libcls_rgw.so): /home/jenkins-build/build/workspace/ceph-pull-requests/build/lib/libcls_rgw.so: undefined symbol: cls_cxx_map_read_header(void*, ceph::buffer::v14_2_0::list*)
Failed to load class: user (/home/jenkins-build/build/workspace/ceph-pull-requests/build/lib/libcls_user.so): /home/jenkins-build/build/workspace/ceph-pull-requests/build/lib/libcls_user.so: undefined symbol: cls_cxx_map_read_header(void*, ceph::buffer::v14_2_0::list*)
Failed to load class: version (/home/jenkins-build/build/workspace/ceph-pull-requests/build/lib/libcls_version.so): /home/jenkins-build/build/workspace/ceph-pull-requests/build/lib/libcls_version.so: undefined symbol: cls_gen_rand_base64(char*, int)

?

tchaikov · 2019-05-27T05:01:31Z

@sebastian-philipp i don't think it's related. i don't even think "Failed to load class" fails the test(s). the reason we have these error messages is that src/test/librados_test_stub/LibradosTestStub.cc only offers the minimum set of APIs used by class objects to support librbd related test.

tchaikov · 2019-05-27T05:14:56Z

#28250 is posted to address these annoying warnings.

This works as a good supplement of ceph#27563. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn> (cherry picked from commit 5d69526) Conflicts: slight conflict from the "Remove dependence on 'using namespac'" change, see ceph#27255

Currently there are various ways to set no{up,down,in,out} flags, by osd, by crush node, or by device class. Use traditional is_no{up,down,in,out} helper to catch-all, and add special wrappers for certain internal consumers. This way osd won't ignore the noup flag set by the new crush node, device class, or any future sources. Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn> (cherry picked from commit 9d11a3a) Conflicts: slight conflict from the "Remove dependence on 'using namespac'" change, see ceph#27255

adamemerson added cleanup core needs-qa common needs-review labels Mar 29, 2019

adamemerson requested a review from tchaikov March 29, 2019 03:30

adamemerson added 24 commits March 29, 2019 10:30

osdc: Update Objecter to work without using namespace

c61ea88

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

osdc: Update Striper to work without using namespace

6c1a215

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

osdc: Update Filer.h to work without using namespace

ce14d64

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

osd: Update osd_types to work without using namespace

75014ce

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

osd: Update OpRequest to work without using namespace

b7746d8

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

osd: Update OSDMap to work without using namespace

a192c1a

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

osd: Update HitSet to work without using namespace

a7676dc

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

osd: Update ECMsgTypes to work without using namespace

d96e891

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

osd: Update OSDMapMapping to work without using namespace

c2ad0f9

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

osd: Update Watch.h to work without using namespace

1f55bd4

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

osd: Update PGPeeringEvent.h to work without using namespace

e7e44ed

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

os: Update ObjectMap.h to work without using namespace

efbd9e1

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

os: Update ObjectStore.h to work without using namespace

850c1d0

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

objclass: Update objclass.h to work without using namespace

b622448

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

msg: Update msg_types.h to work without using namespace

2ae9853

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

msg: Update Messenger.h to work without using namespace

db6efb7

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

msg: Update Message.h to work without using namespace

150ed2b

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

msg: Update Connection.h to work without using namespace

814f528

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

mon: Update mon_types.h to work without using namespace

157162b

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

mon: Update health_check.h to work without using namespace

8d7af2d

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

mon: Update Session.h to work without using namespace

f5d6adb

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

mon: Update PGMap to work without using namespace

b1ea0df

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

mon: Update MonMap to work without using namespace

33108d1

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

mon: Update MonClient to work without using namespace

5475f67

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

adamemerson added 15 commits March 29, 2019 10:30

common: Update CommandTable.h to work without using namespace

a75864d

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

cls/sdk: Update cls_sdk.cc to work without using namespace

fe5e8d3

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

cls/numops: Update cls_numops.cc to work without using namespace

105c425

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

cls/lock: Update cls_lock_types.h to work without using namespace

8bfe6a4

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

journal: Update cls_journal_types.h to work without using namespace

6dc7ee9

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

hello: Update cls_hello.cc to work without using namespace

1430bd7

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

auth: Update KeyRing.h to work without using namespace

510bbe2

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

auth: Update Auth.h to work without using namespace

3a57bea

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

auth: Update AuthClient.h to work without using namespace

eb75a0c

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

auth: Update AuthAuthorizedHandler.h to work without using namespace

883f36e

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

auth: Update AuthClientHandler.h to work without using namespace

e52ef15

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

auth: Update AuthRegistry.h to work without using namespace

093d854

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

auth: Update Crypto.h to work without using namespace

fd42c1e

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

auth: Update AuthServer.h to work without using namespace

6f6ed4f

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

auth: Update AuthServiceHandler.h to work without using namespace

251a4aa

Signed-off-by: Adam C. Emerson <aemerson@redhat.com>

adamemerson force-pushed the wip-names-common-through-objecter branch from 7431d49 to 251a4aa Compare March 29, 2019 14:30

tchaikov approved these changes Apr 1, 2019

View reviewed changes

tchaikov added the wip-kefu-testing label Apr 1, 2019

liewegas added the wip-sage2-testing label Apr 1, 2019

adamemerson removed needs-review needs-qa labels Apr 1, 2019

tchaikov merged commit 53c66a1 into ceph:master Apr 2, 2019

adamemerson deleted the wip-names-common-through-objecter branch April 2, 2019 15:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove dependence on `using namespace`: Build of 'common' through osdc/Objecter.cc #27255

Remove dependence on `using namespace`: Build of 'common' through osdc/Objecter.cc #27255

adamemerson commented Mar 29, 2019

tchaikov commented Apr 1, 2019

tchaikov left a comment

tchaikov Apr 1, 2019

tchaikov Apr 1, 2019

tchaikov commented Apr 2, 2019

sebastian-philipp commented May 23, 2019

tchaikov commented May 27, 2019 •

edited

Loading

tchaikov commented May 27, 2019

		@@ -1,4 +1,4 @@
		// -- mode:C; tab-width:8; c-basic-offset:2; indent-tabs-mode:t --
		// -- mode:C++; tab-width:8; c-basic-offset:2; indent-tabs-mode:t --

Remove dependence on using namespace: Build of 'common' through osdc/Objecter.cc #27255

Remove dependence on using namespace: Build of 'common' through osdc/Objecter.cc #27255

Conversation

adamemerson commented Mar 29, 2019

tchaikov commented Apr 1, 2019

tchaikov left a comment

Choose a reason for hiding this comment

tchaikov Apr 1, 2019

Choose a reason for hiding this comment

tchaikov Apr 1, 2019

Choose a reason for hiding this comment

tchaikov commented Apr 2, 2019

sebastian-philipp commented May 23, 2019

tchaikov commented May 27, 2019 • edited Loading

tchaikov commented May 27, 2019

Remove dependence on `using namespace`: Build of 'common' through osdc/Objecter.cc #27255

Remove dependence on `using namespace`: Build of 'common' through osdc/Objecter.cc #27255

tchaikov commented May 27, 2019 •

edited

Loading