Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src/script/kubejacker: Fix and simplify #27292

Merged

Conversation

sebastian-philipp
Copy link
Contributor

Unfortunately, kubejacker script is not widely used.

In the meantime, simplify it to my needs, as I don't need to push new binaries right now.

Also: updated to new ceph/ceph base image

Signed-off-by: Sebastian Wagner sebastian.wagner@suse.com

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

Unfortunately, kubejacker script is not widely used.

In the meantime, simplify it to my needs, as I don't need to push new binaries right now.

Also: updated to new `ceph/ceph` base image

Fixes: http://tracker.ceph.com/issues/39065

Signed-off-by: Sebastian Wagner <sebastian.wagner@suse.com>
Copy link
Contributor

@jtlayton jtlayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an improvement overall. The original script has bitrotted somewhat.

@jtlayton
Copy link
Contributor

jtlayton commented Apr 3, 2019

retest this please

@sebastian-philipp sebastian-philipp merged commit effc2a3 into ceph:master Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants