messages: #include necessary header #27590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neha-ojha
reviewed
Apr 15, 2019
tchaikov
force-pushed
the
wip-include-cleanup
branch
2 times, most recently
from
f7d2968
to
65310c5
Compare
|
@neha-ojha i updated |
neha-ojha
approved these changes
Apr 18, 2019
|
needs rebase |
* MOSDPGLog.h,MBackfillReserve.h,MOSDPGTrim.h,MRecoveryReserve.h: for instance, MLogRec is defined in PGPeeringEvent.h, we should not rely other header(s) to do this for us. so just #include PGPeeringEvent.h for its definition. * MOSDPeeringOp: do not include PGPeeringEvent.h, as it's not used in this header. forward delcaration would suffice Signed-off-by: Kefu Chai <kchai@redhat.com>
tchaikov
force-pushed
the
wip-include-cleanup
branch
from
65310c5
to
8b84eb6
Compare
liewegas
added a commit
that referenced
this pull request
Apr 29, 2019
* refs/pull/27590/head: messages: #include necessary header Reviewed-by: Neha Ojha <nojha@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for instance, MLogRec is defined in PGPeeringEvent.h, we should not rely
other header(s) to do this for us. so just #include PGPeeringEvent.h for
its definition.
this header. forward delcaration would suffice
Signed-off-by: Kefu Chai kchai@redhat.com