osd: fix erasure hung op bug (9835) #2760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liewegas
force-pushed
the
wip-9835-firefly
branch
from
dad87c0
to
e4307b3
Compare
liewegas
force-pushed
the
wip-9835-firefly
branch
from
e4307b3
to
48c5665
Compare
|
wip-sam-firefly-testing |
|
Calc_pg_role doesn't take into account primary affinity, caused OOO ops. Fixing. |
|
DNM, need to squash first, added updated version to wip-sam-firefly-testing, I think we want something more like this one. |
|
Reviewed-by: This is only failing on EC pools, right? For replicated primary is always == acting[0]? |
Helper to check whether an osd is a given op target for a pg. This assumes that for EC we always send ops to the primary, while for replicated we may target any replica. Signed-off-by: Sage Weil <sage@redhat.com> (cherry picked from commit 89c0263)
Erasure pools do not support read from replica, so we should drop any rank > 0 requests. This fixes a bug where an erasure pool maps to [1,2,3], temporarily maps to [-1,2,3], sends a request to osd.2, and then remaps back to [1,2,3]. Because the 0 shard never appears on osd.2, the request sits in the waiting_for_pg map indefinitely and cases slow request warnings. This problem does not come up on replicated pools because all instances of the PG are created equal. Fix by only considering role == 0 for erasure pools as a correct mapping. Fixes: #9835 Signed-off-by: Sage Weil <sage@redhat.com>
calc_pg_role doesn't actually take into account primary affinity. Fixes: #9835 Signed-off-by: Samuel Just <sam.just@inktank.com>
liewegas
force-pushed
the
wip-9835-firefly
branch
from
79dc1c6
to
fac1654
Compare
|
repushed, with cherry-pick -x from the version for master/next |
athanatos
pushed a commit
that referenced
this pull request
Nov 13, 2014
osd: fix erasure hung op bug (9835) Reviewed-by: Samuel Just <sjust@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.