mon,osd: track history and past_intervals for creating pgs #27696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does not build yet but this feature is super welcome! |
liewegas
force-pushed
the
wip-pg-create-history
branch
from
1c0a060
to
572eac4
Compare
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
Signed-off-by: Sage Weil <sage@redhat.com>
PG create messages from mons are the last case where the OSD may have to scan an unbounded number of old maps in order to construct a valid pg_history_t and PastIntervals. Try to avoid making that a difficult case by maintaining those structures on the monitor. It is still possible that the mon may send a pg create message to the OSD and it sits in a message queue for a very long time, but this would be a very difficult situation to get into, and is no different from inter-OSD messages that include history and past_intervals. Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-pg-create-history
branch
from
572eac4
to
53c357a
Compare
If we get a mismatched epoch and past_intervals, error out early, or else we'll end up asserting later in the PastIntervals code. Signed-off-by: Sage Weil <sage@redhat.com>
liewegas
force-pushed
the
wip-pg-create-history
branch
from
53c357a
to
b9865ad
Compare
neha-ojha
approved these changes
Apr 23, 2019
liewegas
added a commit
that referenced
this pull request
Apr 24, 2019
* refs/pull/27696/head: osd: make use of pg history and past_intervals in pg_create2 messages mon/OSDMonitor: track history and past_intervals for creating pgs osd/osd_types: make PastIntervals pi_compact_rep print participants osd/osd_types: take bare const OSDMap * to check_new_interval osd/osd_types: add pg_history_t ctor that takes creation epoch+stamp Reviewed-by: Neha Ojha <nojha@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PG create messages from mons are the last case where the OSD may have to
scan an unbounded number of old maps in order to construct a valid
pg_history_t and PastIntervals. Try to avoid making that a difficult case
by maintaining those structures on the monitor.
https://trello.com/c/wselOluN/412-mon-track-pastintervals-and-history-for-creating-pgs