cephfs-shell: Fix mkdir relative path error #27822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test make check arm64 |
batrick
requested changes
May 8, 2019
src/tools/cephfs/cephfs-shell
Outdated
| if cwd is '/': | ||
| path = to_bytes(cwd + dir_name) | ||
| else: | ||
| path = to_bytes(cwd + '/' + dir_name) |
There was a problem hiding this comment.
I don't think we should need to do any of this processing. libcephfs already has a concept of a current working directory and should handle all paths correctly. No preprocessing in cephfs-shell should be required.
The original code is wrong though. It should not be prepending a /. Can you remove that and give it another try? If that works, please remove the other instances of that if you find any.
There was a problem hiding this comment.
Thank you for explaining. Removing '/' works here. Few other places, where it has been used causes error if removed.
Directory is not created for relative path. This patch fixes it. Fixes: https://tracker.ceph.com/issues/39507 Signed-off-by: Varsha Rao <varao@redhat.com>
varshar16
force-pushed
the
wip-cephfs-mkdir-error
branch
from
fd93409
to
e892876
Compare
batrick
approved these changes
May 14, 2019
batrick
added a commit
that referenced
this pull request
May 15, 2019
* refs/pull/27822/head: cephfs-shell: Fix mkdir relative path error Reviewed-by: Patrick Donnelly <pdonnell@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Directory is not created for relative path. This patch fixes it.
Fixes: https://tracker.ceph.com/issues/39507
Signed-off-by: Varsha Rao varao@redhat.com