Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nautilus: mgr/prometheus: replace whitespaces in metrics' names #27886

Merged
merged 1 commit into from
May 7, 2019
Merged

nautilus: mgr/prometheus: replace whitespaces in metrics' names #27886

merged 1 commit into from
May 7, 2019

Conversation

alfonsomthd
Copy link
Contributor

@alfonsomthd alfonsomthd commented Apr 30, 2019 •
edited by smithfarm
Loading

@b-ranto b-ranto changed the title mgr/prometheus: replace whitespaces in metrics' names [nautilus] mgr/prometheus: replace whitespaces in metrics' names Apr 30, 2019
@b-ranto
Copy link
Contributor

b-ranto commented Apr 30, 2019

Hey Alfonso, any plans on back-porting the PR that removes the spaces from the rgw perf counters?

@alfonsomthd
Copy link
Contributor Author

Hey Alfonso, any plans on back-porting the PR that removes the spaces from the rgw perf counters?

@theanalyst Any updates on this?

@s0nea s0nea added this to the nautilus milestone Apr 30, 2019
s0nea
s0nea reviewed Apr 30, 2019
View reviewed changes
Copy link
Member

@s0nea s0nea left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @alfonsomthd did you use git cherry-pick -x <commit id> to cherry-pick the commit? - The commit message seems a bit incomplete.

@s0nea s0nea changed the title [nautilus] mgr/prometheus: replace whitespaces in metrics' names nautilus: mgr/prometheus: replace whitespaces in metrics' names Apr 30, 2019
@alfonsomthd
mgr/prometheus: replace whitespaces in metrics' names
e9e11cd 
Fixes: https://tracker.ceph.com/issues/39434

Signed-off-by: Alfonso Martínez <almartin@redhat.com>
(cherry picked from commit 843802f)
@alfonsomthd alfonsomthd force-pushed the 39459-nautilus-prometheus-replace-whitespaces branch from 20924da to e9e11cd Compare April 30, 2019 10:41
@cbodley
Copy link
Contributor

cbodley commented Apr 30, 2019

@alfonsomthd pr #27725 was associated with the same tracker issue https://tracker.ceph.com/issues/39434, so it's probably best for you to cherry-pick it into this pr

smithfarm
smithfarm suggested changes May 1, 2019
View reviewed changes
Copy link
Contributor

@smithfarm smithfarm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please cherry-pick 97fb4ee into this PR as requested by @cbodley

@alfonsomthd
Copy link
Contributor Author

please cherry-pick 97fb4ee into this PR as requested by @cbodley

Hi @cbodley @smithfarm It seems that commit d611fe9
is not backported to nautilus branch, so file "src/rgw/rgw_sync_counters.cc" does not exist.
How should we proceed?

@cbodley cbodley mentioned this pull request May 2, 2019
Merged
@cbodley
Copy link
Contributor

cbodley commented May 2, 2019

oops, thanks @alfonsomthd. i just did the backport for that in #27921, and pulled in the extra commit 97fb4ee there

@alfonsomthd alfonsomthd requested a review from smithfarm May 6, 2019 07:56
@LenzGr LenzGr merged commit 88ce715 into ceph:nautilus May 7, 2019
@alfonsomthd alfonsomthd deleted the 39459-nautilus-prometheus-replace-whitespaces branch April 9, 2020 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s0nea s0nea s0nea left review comments

@cbodley cbodley cbodley approved these changes

@smithfarm smithfarm smithfarm approved these changes

@LenzGr LenzGr Awaiting requested review from LenzGr

@b-ranto b-ranto Awaiting requested review from b-ranto

Assignees
No one assigned
Labels
mgr nautilus-batch-1 nautilus point releases needs-qa
Projects
None yet
Milestone
nautilus
Development

Successfully merging this pull request may close these issues.
6 participants
@alfonsomthd @b-ranto @cbodley @smithfarm @s0nea @LenzGr