mgr/dashboard: Optimize portal IPs calculation #28084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins retest this please |
|
jenkins test make check arm64 |
ricardoasmarques
force-pushed
the
improve-portal-ips-calculation
branch
from
67690b0
to
41a23e6
Compare
|
jenkins retest this please |
1 similar comment
|
jenkins retest this please |
Now that portal IPs are part of the ceph-iscsi config we don't have to calculate this information, we just use the `portal_ip_addresses` field. Fixes: https://tracker.ceph.com/issues/39580 Signed-off-by: Ricardo Marques <rimarques@suse.com>
ricardoasmarques
force-pushed
the
improve-portal-ips-calculation
branch
from
41a23e6
to
7107bf9
Compare
|
jenkins retest this please |
|
jenkins test make check arm64 |
tspmelo
approved these changes
May 28, 2019
|
@ricardoasmarques good to merge? |
|
@tchaikov Yes, good to merge. |
tchaikov
added a commit
to tchaikov/ceph
that referenced
this pull request
Jun 11, 2019
it's a follow-up fix of ceph#28084 Signed-off-by: Kefu Chai <kchai@redhat.com>
3 tasks
tchaikov
added a commit
to tchaikov/ceph
that referenced
this pull request
Jun 12, 2019
and take portal_ip_addresses as a list it's a follow-up fix of ceph#28084 Signed-off-by: Kefu Chai <kchai@redhat.com>
s0nea
pushed a commit
to s0nea/ceph_ceph
that referenced
this pull request
Jul 16, 2019
and take portal_ip_addresses as a list it's a follow-up fix of ceph#28084 Signed-off-by: Kefu Chai <kchai@redhat.com> (cherry picked from commit ddeda90)
dziomdziorae
pushed a commit
to dziomdziorae/ceph
that referenced
this pull request
Jul 23, 2019
and take portal_ip_addresses as a list it's a follow-up fix of ceph#28084 Signed-off-by: Kefu Chai <kchai@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that portal IPs are part of the ceph-iscsi config (since ceph/ceph-iscsi#63) we don't have to calculate this information, we just use the
portal_ip_addressesfield returned by ceph-iscsi directly.Signed-off-by: Ricardo Marques rimarques@suse.com