Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mimic: rbd: librbd: async open/close should free ImageCtx before issuing callback #28125

Merged
merged 2 commits into from Oct 8, 2019

Conversation

@dillaman
Copy link
Contributor

dillaman commented May 15, 2019

@dillaman dillaman added this to the mimic milestone May 15, 2019
@smithfarm

This comment has been minimized.

Copy link
Contributor

smithfarm commented Oct 1, 2019

@dillaman Please rebase

dillaman added 2 commits Apr 18, 2019
The destructor for ImageCtx attempts to access librados::IoCtx objects
that might have been destroyed immediately after the async open (failure)
and close actions completed.

Fixes: http://tracker.ceph.com/issues/39031
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit be419a1)

Conflicts:
	src/librbd/io/AioCompletion.cc: assert->ceph_assert confict
Signed-off-by: Jason Dillaman <dillaman@redhat.com>
(cherry picked from commit ba52f42)
@dillaman dillaman force-pushed the dillaman:wip-39429-mimic branch from 3a43a5e to 133a0f8 Oct 1, 2019
@dillaman dillaman removed the needs-rebase label Oct 1, 2019
@dillaman

This comment has been minimized.

Copy link
Contributor Author

dillaman commented Oct 1, 2019

@smithfarm done

@smithfarm smithfarm changed the title mimic: librbd: async open/close should free ImageCtx before issuing callback mimic: rbd: librbd: async open/close should free ImageCtx before issuing callback Oct 1, 2019
@yuriw

This comment has been minimized.

Copy link
Contributor

yuriw commented Oct 4, 2019

@yuriw yuriw merged commit 0a861a3 into ceph:mimic Oct 8, 2019
4 checks passed
4 checks passed
Docs: build check OK - docs built
Details
Signed-off-by all commits in this PR are signed
Details
Unmodified Submodules submodules for project are unmodified
Details
make check make check succeeded
Details
@dillaman dillaman deleted the dillaman:wip-39429-mimic branch Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.