-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nautilus: mgr/dashboard: Unify the look of dashboard charts #28175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: http://tracker.ceph.com/issues/39384 Signed-off-by: Tiago Melo <tmelo@suse.com> (cherry picked from commit bcbc0ed)
jenkins re-test this please |
tspmelo
changed the title
nautilus: mgr/dashboard: Unify the look of dashboard charts
[After #28178] nautilus: mgr/dashboard: Unify the look of dashboard charts
May 20, 2019
This should be merged after #28178, otherwise it will require modifications to the original commit. |
LenzGr
approved these changes
May 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
jenkins test make check |
retest this please |
tspmelo
changed the title
[After #28178] nautilus: mgr/dashboard: Unify the look of dashboard charts
nautilus: mgr/dashboard: Unify the look of dashboard charts
Jun 7, 2019
jenkins retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://tracker.ceph.com/issues/39961