Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nautilus: mgr/dashboard: Unify the look of dashboard charts #28175

Merged
merged 1 commit into from
Jun 11, 2019

Conversation

tspmelo
Copy link
Contributor

@tspmelo tspmelo commented May 20, 2019

Fixes: http://tracker.ceph.com/issues/39384

Signed-off-by: Tiago Melo <tmelo@suse.com>
(cherry picked from commit bcbc0ed)
@tspmelo tspmelo self-assigned this May 20, 2019
@tspmelo tspmelo added this to the nautilus milestone May 20, 2019
@tspmelo tspmelo requested a review from LenzGr May 20, 2019 11:50
@smithfarm
Copy link
Contributor

jenkins re-test this please

@tspmelo tspmelo added the DNM label May 20, 2019
@tspmelo tspmelo changed the title nautilus: mgr/dashboard: Unify the look of dashboard charts [After #28178] nautilus: mgr/dashboard: Unify the look of dashboard charts May 20, 2019
@tspmelo
Copy link
Contributor Author

tspmelo commented May 20, 2019

This should be merged after #28178, otherwise it will require modifications to the original commit.

Copy link
Contributor

@LenzGr LenzGr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ricardoasmarques
Copy link
Contributor

jenkins test make check

@tchaikov
Copy link
Contributor

retest this please

@tspmelo tspmelo changed the title [After #28178] nautilus: mgr/dashboard: Unify the look of dashboard charts nautilus: mgr/dashboard: Unify the look of dashboard charts Jun 7, 2019
@tspmelo tspmelo removed the DNM label Jun 7, 2019
@tspmelo
Copy link
Contributor Author

tspmelo commented Jun 7, 2019

jenkins retest this please

@yuriw
Copy link
Contributor

yuriw commented Jun 10, 2019

@yuriw yuriw merged commit 2954439 into ceph:nautilus Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants