Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nautilus: mgr/dashboard: Display correct dialog title #28189

Merged
merged 1 commit into from
May 31, 2019
Merged

nautilus: mgr/dashboard: Display correct dialog title #28189

merged 1 commit into from
May 31, 2019

Conversation

votdev
Copy link
Member

@votdev votdev commented May 21, 2019 •
edited
Loading

https://tracker.ceph.com/issues/40048

Signed-off-by: Volker Theile vtheile@suse.com
(cherry picked from commit c87e21d)

@ricardoasmarques
Copy link
Contributor

Adding the DNM label because the original PR #28168 was not merged yet.

@callithea callithea added this to the nautilus milestone May 24, 2019
@LenzGr LenzGr requested review from epuertat and Devp00l May 27, 2019 08:55
@votdev
Copy link
Member Author

votdev commented May 27, 2019

jenkins retest this please

@votdev
mgr/dashboard: Display correct dialog title
4b9d3c4 
The dialog to create a new S3 key shows the title 'Show S3 key' instead of 'Create S3 key'.

Fixes: https://tracker.ceph.com/issues/40047

Signed-off-by: Volker Theile <vtheile@suse.com>
(cherry picked from commit c87e21d)
@votdev votdev added needs-review and removed DNM labels May 29, 2019
ricardoasmarques
ricardoasmarques approved these changes May 29, 2019
View reviewed changes
Copy link
Contributor

@ricardoasmarques ricardoasmarques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smithfarm smithfarm added nautilus-batch-1 nautilus point releases needs-qa and removed needs-review labels May 29, 2019
Devp00l
Devp00l approved these changes May 29, 2019
View reviewed changes
Copy link

@Devp00l Devp00l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yuriw
Copy link
Contributor

yuriw commented May 29, 2019

wip-yuri5-testing-2019-05-29-1613-nautilus

@yuriw yuriw merged commit c942e49 into ceph:nautilus May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LenzGr LenzGr LenzGr approved these changes

@ricardoasmarques ricardoasmarques ricardoasmarques approved these changes

@Devp00l Devp00l Devp00l approved these changes

@epuertat epuertat Awaiting requested review from epuertat

Assignees

@LenzGr LenzGr

@tspmelo tspmelo

@ricardoasmarques ricardoasmarques

@Devp00l Devp00l

Labels
bug-fix dashboard nautilus-batch-1 nautilus point releases needs-qa wip-yuri5-testing
Projects
None yet
Milestone
nautilus
Development

Successfully merging this pull request may close these issues.
8 participants
@votdev @ricardoasmarques @yuriw @LenzGr @Devp00l @tspmelo @smithfarm @callithea