-
Notifications
You must be signed in to change notification settings - Fork 5.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
buffer.h: remove list::iterator_impl::advance(size_t) #28278
Merged
tchaikov
merged 1 commit into
ceph:master
from
tchaikov:wip-buffer-remove-advance-size_t
May 30, 2019
Merged
buffer.h: remove list::iterator_impl::advance(size_t) #28278
tchaikov
merged 1 commit into
ceph:master
from
tchaikov:wip-buffer-remove-advance-size_t
May 30, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 29, 2019
javacruft
approved these changes
May 29, 2019
|
09375e2
to
1e315ec
Compare
1e315ec
to
03e857c
Compare
changelog
|
rzarzynski
approved these changes
May 29, 2019
tchaikov
commented
May 29, 2019
quote from Radoslaw's comment > In general we could remove it as the `buffer` library tends to > disrespects `size_t` – `list::_len` and `ptr::_len` are both `unsigned`. > There are some exceptions like `size_t buffer::ptr::get_offset()` (used > altogether with `::advance` in `denc.h`) but they deserve rework as > well. and in this very case, we simply cast `size_t` to `unsigned`. so we could silently trim a 64bits integer to 32bit on 64bits architecture. so for better portability, we can just remove it. also, this function is inlined, so the ABI is not changed. Signed-off-by: Kefu Chai <kchai@redhat.com>
03e857c
to
a9f8b1a
Compare
changelog
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
quote from Radoslaw's comment
and in this very case, we simply cast
size_t
tounsigned
. so wecould silently trim a 64bits integer to 32bit on 64bits architecture.
so for better portability, we can just remove it. also, this function is
inlined, so the ABI is not changed.
Signed-off-by: Kefu Chai kchai@redhat.com