Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osd/OSD: keep synchronizing with mon if stuck at booting #28404

Merged
merged 1 commit into from
Jun 14, 2019

Conversation

xiexingguo
Copy link
Member

During the flapping no{up,down,in,out} flags test I've noticed
that some osds might be stuck at down&booting state due to the
unawareness of noup flag changing.
Fix by subscribing (continuous) to next osd map, just as we do
if we are stuck at unhealthy.

Signed-off-by: xie xingguo xie.xingguo@zte.com.cn

  • References tracker ticket
  • Updates documentation if necessary
  • Includes tests for new functionality or reproducer for bug

During the flapping no{up,down,in,out} flags test I've noticed
that some osds might be stuck at down&booting state due to the
unawareness of noup flag changing.
Fix by subscribing (continuous) to next osd map, just as we do
if we are stuck at unhealthy.

Signed-off-by: xie xingguo <xie.xingguo@zte.com.cn>
@xiexingguo
Copy link
Member Author

@liewegas Can you review this one too? Thanks!

Copy link
Member

@liewegas liewegas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

I think the osdmap_subscribe machinery could use a bit of a cleanup at some point (i'm not sure the force_request still works the way it originally did?), but that's tangential to this.

@tchaikov tchaikov merged commit fae1577 into ceph:master Jun 14, 2019
@xiexingguo xiexingguo deleted the wip-osd-noup-stall branch June 14, 2019 08:56
@xiexingguo
Copy link
Member Author

@tchaikov Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants